Skip to content

Commit 016c43b

Browse files
excelle08facebook-github-bot
authored andcommitted
Log main_benchmark start/end for the final measurement in search_qps.sh
Differential Revision: D113485984
1 parent fb77ccc commit 016c43b

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

packages/feedsim/third_party/src/scripts/search_qps.sh

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -546,7 +546,7 @@ if [[ -n "$fixed_qps" ]]; then
546546
else
547547
for fixed_qps_el in $fixed_qps_array; do
548548
benchreps_tell_state "before fixed_qps_iter $fixed_qps_el"
549-
run_loadtest measured_qps measured_latency $fixed_qps_el ""
549+
run_loadtest measured_qps measured_latency $fixed_qps_el "$main_operation_name"
550550
printf "final requested_qps = %.2f, measured_qps = %.2f, latency = %.2f\n" $fixed_qps_el $measured_qps $measured_latency
551551
echo "final requested_qps = $fixed_qps_el, measured_qps = $measured_qps, latency = $measured_latency" >> $BREPS_LFILE
552552
benchreps_tell_state "after fixed_qps_iter $fixed_qps_el"
@@ -721,13 +721,17 @@ if [[ -n "$IS_AUTOSCALE_RUN" ]] && [[ "$IS_AUTOSCALE_RUN" -gt 1 ]]; then
721721
fi
722722
fi
723723

724-
# do final measurement
724+
# do final measurement — this is the actual reported experiment window; log it
725+
# as main_benchmark in breakdown.csv so perfpub sees a valid time window (the
726+
# search/warmup/tuning probes above are informational and should not be logged
727+
# as the primary benchmark window). $main_operation_name comes from
728+
# packages/common/runtime_breakdown_utils.sh (sourced at the top of this script).
725729
benchreps_tell_state "before final_qps"
726730
experiment_time=$final_experiment_time
727731
if [ "${DCPERF_PERF_RECORD}" = 1 ] && ! [ -f "perf.data" ]; then
728732
collect_perf_record &
729733
fi
730-
run_loadtest measured_qps measured_latency $cur_qps ""
734+
run_loadtest measured_qps measured_latency $cur_qps "$main_operation_name"
731735
printf "final requested_qps = %.2f, measured_qps = %.2f, latency = %.2f\n" $cur_qps $measured_qps $measured_latency
732736

733737
# report non-converging error if iteration reaches max tries

0 commit comments

Comments
 (0)