Skip to content

Commit da47924

Browse files
committed
update docs and make critical path official feature
1 parent 8cb28f8 commit da47924

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

docs/source/features/lightweight_critical_path_analysis.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ This version of **Critical Path Analysis does not need Execution Traces.**
6363
Using Critical Path Analysis
6464
----------------------------
6565

66-
This `ipython notebook <https://github.com/facebookresearch/HolisticTraceAnalysis/blob/main/examples/experimental/critical_path_analysis.ipynb>`__
66+
This `ipython notebook <https://github.com/facebookresearch/HolisticTraceAnalysis/blob/main/examples/critical_path_analysis.ipynb>`__
6767
illustrates basic critical path analysis.
6868

6969
Prerequisite
@@ -77,7 +77,7 @@ This was fixed in `PR1 <https://github.com/pytorch/pytorch/pull/105187>`__ and `
7777
Analysis:
7878
^^^^^^^^^
7979

80-
As shown in the `notebook <https://github.com/facebookresearch/HolisticTraceAnalysis/blob/main/examples/experimental/critical_path_analysis.ipynb>`__, use ``analyzer.critical_path_analysis()`` for trace events within a single rank.
80+
As shown in the `notebook <https://github.com/facebookresearch/HolisticTraceAnalysis/blob/main/examples/critical_path_analysis.ipynb>`__, use ``analyzer.critical_path_analysis()`` for trace events within a single rank.
8181
We can further reduce the region of interest by selecting a *trace annotation* and instance id.
8282
For example, you can use this to limit the analysis to one iteration by passing annotation 'ProfilerStep#500'.
8383

0 commit comments

Comments
 (0)