Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

[bert_ranker] Should be overriding build_criterion #2019

Open
stephenroller opened this issue Sep 26, 2019 · 1 comment
Open

[bert_ranker] Should be overriding build_criterion #2019

stephenroller opened this issue Sep 26, 2019 · 1 comment
Labels
CS5152 Tasks for CS5152 participants donotreap Avoid automatically marking as stale. Help Wanted Minor

Comments

@stephenroller
Copy link
Contributor

Bug description
Created from #2003.

The self.rank_loss in bi_encode_ranker (and possibly the others) should be created by overriding the build_criterion rather than directionly setting self.rank_loss.

ParlAI/parlai/agents/bert_ranker/bi_encoder_ranker.py

Line 57 in 028753f

self.rank_loss = torch.nn.CrossEntropyLoss(reduce=True, size_average=True)

@stephenroller stephenroller added the CS5152 Tasks for CS5152 participants label Sep 26, 2019
@stephenroller stephenroller mentioned this issue Sep 26, 2019
Merged
@github-actions
Copy link

github-actions bot commented Jun 2, 2020

This issue has not had activity in 30 days. Marking as stale.

@github-actions github-actions bot closed this as completed Jun 2, 2020
@stephenroller stephenroller reopened this Jun 2, 2020
@stephenroller stephenroller added donotreap Avoid automatically marking as stale. and removed stale-issue labels Jun 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CS5152 Tasks for CS5152 participants donotreap Avoid automatically marking as stale. Help Wanted Minor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stephenroller @klshuster