You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Currently, ImageSeq2seqAgent and ImagePolyencoderAgent have two separate .batchify_image_features() methods for preparing image features for encoding. The main advantage of ImagePolyencoderAgent's implementation of this method is that the images are packed into a Tensor for data_parallel. It's worth testing whether ImageSeq2seqAgent really requires a separate .batchify_image_features() method now: if not, it should be removed, and ImagePolyencoderAgent.batchify_image_features() should be moved into TorchImageAgent.
The text was updated successfully, but these errors were encountered:
@stephenroller Hmm there are still two different .batchify_image_features() methods in ImagePolyencoderAgent and ImageSeq2seqAgent, so as far as I know this is still an open issue. @klshuster may be able to speak more on this because he's been refactoring some of this code recently
Currently,
ImageSeq2seqAgent
andImagePolyencoderAgent
have two separate.batchify_image_features()
methods for preparing image features for encoding. The main advantage ofImagePolyencoderAgent
's implementation of this method is that the images are packed into a Tensor for data_parallel. It's worth testing whetherImageSeq2seqAgent
really requires a separate.batchify_image_features()
method now: if not, it should be removed, andImagePolyencoderAgent.batchify_image_features()
should be moved intoTorchImageAgent
.The text was updated successfully, but these errors were encountered: