Skip to content

Commit 40bd3a4

Browse files
generatedunixname1228101065403401meta-codesync[bot]
authored andcommitted
Fix PYRE_FIXME issue in fbcode/pearl/policy_learners/exploration_modules/contextual_bandits/squarecb_exploration.py
Differential Revision: D103670355 fbshipit-source-id: db725bc5ec0d780248ead9372db5492a19bae9b8
1 parent 0df4f08 commit 40bd3a4

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

pearl/policy_learners/exploration_modules/contextual_bandits/squarecb_exploration.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
import torch
1313
from pearl.api.action import Action
14+
from pearl.api.action_space import ActionSpace
1415
from pearl.api.state import SubjectiveState
1516
from pearl.policy_learners.exploration_modules import ExplorationModule
1617
from pearl.policy_learners.exploration_modules.common.score_exploration_base import (
@@ -114,16 +115,15 @@ def get_unnormalize_prob(
114115
"""
115116
return torch.div(1.0, action_num + self._gamma * empirical_gaps)
116117

117-
# pyre-fixme[14]: `act` overrides method defined in `ScoreExplorationBase`
118-
# inconsistently.
119118
def get_scores(
120119
self,
121120
subjective_state: SubjectiveState,
122-
action_space: DiscreteActionSpace,
121+
action_space: ActionSpace,
123122
values: torch.Tensor,
124123
exploit_action: Action | None = None,
125124
representation: torch.nn.Module | None = None,
126125
) -> Action:
126+
assert isinstance(action_space, DiscreteActionSpace)
127127
return values.view(-1, action_space.n)
128128

129129
def compare(self, other: ExplorationModule) -> str:

0 commit comments

Comments
 (0)