Commit 4ddce21
patch: minor fix in q value networks (#120)
Summary:
Change:
- The `CNNQValueMultiHeadNetwork.get_q_values` method now checks `len(action_batch.shape)` when deciding whether to squeeze the returned tensor instead of using `len(action_batch)`.
Why?
- The previous logic misinterpreted a 3‑D action tensor: `len(action_batch)` returned the batch size rather than the number of dimensions, causing incorrect squeezing behavior and potentially wrong output shapes.
Pull Request resolved: #120
Reviewed By: Yonathae
Differential Revision: D78899714
Pulled By: rodrigodesalvobraz
fbshipit-source-id: f48612c3beb4124681418992bfa02d355d95cfc81 parent 1265290 commit 4ddce21
1 file changed
Lines changed: 1 addition & 1 deletion
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
912 | 912 | | |
913 | 913 | | |
914 | 914 | | |
915 | | - | |
| 915 | + | |
916 | 916 | | |
917 | 917 | | |
918 | 918 | | |
| |||
0 commit comments