Skip to content

Commit 863df8d

Browse files
JasonKChowfacebook-github-bot
authored andcommitted
Change test qNEI to qLogNEI (#729)
Summary: Pull Request resolved: #729 Tests that used qNEI now use qLogNEI to match latest recommendations from botorch. Reviewed By: adellari Differential Revision: D72430600 fbshipit-source-id: f2fb623755981bb11aae63d04e4efe9f9c0c99a9
1 parent 98f6123 commit 863df8d

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

tests/models/test_gp_regression.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ def setUp(self):
4747
strategy_names = [init_strat, opt_strat]
4848
4949
[init_strat]
50-
min_asks = 10
50+
min_asks = 20
5151
generator = SobolGenerator
5252
5353
[opt_strat]
@@ -56,7 +56,7 @@ def setUp(self):
5656
model = GPRegressionModel
5757
5858
[OptimizeAcqfGenerator]
59-
acqf = qNoisyExpectedImprovement
59+
acqf = qLogNoisyExpectedImprovement
6060
6161
[GPRegressionModel]
6262
likelihood = GaussianLikelihood

tests_gpu/models/test_gp_regression.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ def setUp(self):
4545
strategy_names = [init_strat, opt_strat]
4646
4747
[init_strat]
48-
min_asks = 10
48+
min_asks = 20
4949
generator = SobolGenerator
5050
5151
[opt_strat]
@@ -58,7 +58,7 @@ def setUp(self):
5858
max_fit_time = 1
5959
6060
[OptimizeAcqfGenerator]
61-
acqf = qNoisyExpectedImprovement
61+
acqf = qLogNoisyExpectedImprovement
6262
"""
6363
self.server = AEPsychServer(database_path=dbname)
6464
configure(self.server, config_str=config)

0 commit comments

Comments
 (0)