Skip to content

fairchem.core.models.utils.basis is not compatible with scipy >=1.17.0 #1717

@harveydevereux

Description

@harveydevereux

What would you like to report?

scipy.special.sph_harm was removed last week. It is used in src/fairchem/core/models/utils/basis.py. But it is not clear where this file is actually used in this repo.

It was used in (fairchem_core-1.10.0) OCPCalculator, via fairchem.core.common.utils.setup_imports , which can fail to instantiate due to this (as it did in CI for a project I work on). The UMA/FAIRChemCalculator readme examples in main of v2 work fine (and in our CI).

Neither src/fairchem/core/models/utils/basis.py or fairchem.core.common.utils.setup_imports appear to be referenced in main.

Is this code orphaned? Or is it somehow used with particular models (packaged code)? Meaning that it needs to be pinned to scipy < 1.17.0 or updated.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions