Skip to content

Commit 04e543c

Browse files
committed
fix lint
1 parent d372d27 commit 04e543c

5 files changed

Lines changed: 26 additions & 19 deletions

File tree

src/fairseq2/models/qwen/__init__.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,9 @@
1212
from fairseq2.models.qwen.config import Qwen35Config as Qwen35Config
1313
from fairseq2.models.qwen.config import Qwen35MoeConfig as Qwen35MoeConfig
1414
from fairseq2.models.qwen.config import QwenConfig as QwenConfig
15-
from fairseq2.models.qwen.config import register_qwen35_configs as register_qwen35_configs
15+
from fairseq2.models.qwen.config import (
16+
register_qwen35_configs as register_qwen35_configs,
17+
)
1618
from fairseq2.models.qwen.config import (
1719
register_qwen35_moe_configs as register_qwen35_moe_configs,
1820
)
@@ -32,7 +34,9 @@
3234
from fairseq2.models.qwen.hub import (
3335
get_qwen35_moe_tokenizer_hub as get_qwen35_moe_tokenizer_hub,
3436
)
35-
from fairseq2.models.qwen.hub import get_qwen35_tokenizer_hub as get_qwen35_tokenizer_hub
37+
from fairseq2.models.qwen.hub import (
38+
get_qwen35_tokenizer_hub as get_qwen35_tokenizer_hub,
39+
)
3640
from fairseq2.models.qwen.hub import get_qwen_model_hub as get_qwen_model_hub
3741
from fairseq2.models.qwen.hub import get_qwen_tokenizer_hub as get_qwen_tokenizer_hub
3842
from fairseq2.models.qwen.interop import (

src/fairseq2/models/qwen/attention.py

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -89,22 +89,30 @@ def __init__(
8989
# Q projection is DOUBLED — half query, half gate.
9090
# HF: nn.Linear(hidden, num_heads * head_dim * 2, bias=False)
9191
self.q_proj = Linear(
92-
model_dim, num_heads * head_dim * 2, bias=False,
92+
model_dim,
93+
num_heads * head_dim * 2,
94+
bias=False,
9395
init_fn=qkv_proj_init_fn,
9496
)
9597

9698
self.k_proj = Linear(
97-
model_dim, num_key_value_heads * head_dim, bias=False,
99+
model_dim,
100+
num_key_value_heads * head_dim,
101+
bias=False,
98102
init_fn=qkv_proj_init_fn,
99103
)
100104

101105
self.v_proj = Linear(
102-
model_dim, num_key_value_heads * head_dim, bias=False,
106+
model_dim,
107+
num_key_value_heads * head_dim,
108+
bias=False,
103109
init_fn=qkv_proj_init_fn,
104110
)
105111

106112
self.output_proj = Linear(
107-
num_heads * head_dim, model_dim, bias=False,
113+
num_heads * head_dim,
114+
model_dim,
115+
bias=False,
108116
init_fn=output_proj_init_fn,
109117
)
110118

@@ -163,12 +171,8 @@ def forward(
163171
k_rot = k[..., :encoding_dim]
164172
k_pass = k[..., encoding_dim:]
165173

166-
q_rot = self.pos_encoder(
167-
q_rot, seqs_layout, state_bag=state_bag
168-
)
169-
k_rot = self.pos_encoder(
170-
k_rot, keys_layout, state_bag=state_bag
171-
)
174+
q_rot = self.pos_encoder(q_rot, seqs_layout, state_bag=state_bag)
175+
k_rot = self.pos_encoder(k_rot, keys_layout, state_bag=state_bag)
172176

173177
q = torch.cat([q_rot, q_pass], dim=-1)
174178
k = torch.cat([k_rot, k_pass], dim=-1)
@@ -198,9 +202,7 @@ def forward(
198202

199203
# -- Scaled dot-product attention --
200204
# q, k, v: (B, S, H, D)
201-
attn_output, _ = self.sdpa(
202-
q, seqs_layout, k, keys_layout, v, bias_cache
203-
)
205+
attn_output, _ = self.sdpa(q, seqs_layout, k, keys_layout, v, bias_cache)
204206

205207
# -- Output gating --
206208
# attn_output: (B, S, H, D) -> (B, S, H * D)

src/fairseq2/models/qwen/config.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,8 @@ class QwenConfig:
6565

6666
pad_idx: int | None = None
6767
"""The index of the pad symbol in the vocabulary."""
68+
69+
6870
# ---------------------------------------------------------------------------
6971

7072

src/fairseq2/models/qwen/decoder_layer.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -114,9 +114,7 @@ def forward(
114114
*,
115115
state_bag: IncrementalStateBag | None = None,
116116
) -> Tensor:
117-
seqs = self._forward_token_mixer(
118-
seqs, seqs_layout, attn_bias_cache, state_bag
119-
)
117+
seqs = self._forward_token_mixer(seqs, seqs_layout, attn_bias_cache, state_bag)
120118
seqs = self._forward_ffn(seqs)
121119
return seqs
122120

src/fairseq2/models/qwen/interop.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ def convert_qwen_state_dict(
4747

4848
return state_dict
4949

50+
5051
# HG-side RMSNorm key suffixes for reverse conversion (weight -= 1.0).
5152
_QWEN35_HG_RMSNORM_SUFFIXES = (
5253
"input_layernorm.weight",
@@ -287,7 +288,7 @@ def _expand_with_language_model_prefix(
287288
# Components not yet integrated in the text-only CausalLM model.
288289
_QWEN35_VL_SKIP_PREFIXES: Final = (
289290
"model.visual.", # vision encoder
290-
"mtp.", # multi-token prediction head
291+
"mtp.", # multi-token prediction head
291292
)
292293

293294

0 commit comments

Comments
 (0)