From 6b324e401f501ad6ab6a2026673a96215beeb4ba Mon Sep 17 00:00:00 2001 From: jacklanchantin Date: Thu, 24 Jul 2025 20:22:47 +0000 Subject: [PATCH 1/4] add new args for reward_handler.create --- src/fairseq2/recipes/lm/_online_finetune/_online_dpo.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/fairseq2/recipes/lm/_online_finetune/_online_dpo.py b/src/fairseq2/recipes/lm/_online_finetune/_online_dpo.py index 64755a3f2..6c48afa46 100644 --- a/src/fairseq2/recipes/lm/_online_finetune/_online_dpo.py +++ b/src/fairseq2/recipes/lm/_online_finetune/_online_dpo.py @@ -456,10 +456,13 @@ def create( vllm_reward_model = vllm_actors.get(config.vllm_reward_model_actor_name, None) reward_registry = self._context.get_registry(VLLMOutputRewardHandler) reward_handler = reward_registry.get(config.reward.name) + reward_name = config.reward.name reward = reward_handler.create( reward_model=vllm_reward_model, + reward_name=reward_name, reward_config=config.reward.config, gangs=gangs, + context=self._context, ) # TODO: decide converter as part of the model handler From 3a9a7dbce74ec1a7c9aad0012100ef9c2dac37f3 Mon Sep 17 00:00:00 2001 From: jacklanchantin Date: Thu, 24 Jul 2025 20:22:57 +0000 Subject: [PATCH 2/4] add qwen25_3b --- src/fairseq2/assets/cards/models/qwen.yaml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/src/fairseq2/assets/cards/models/qwen.yaml b/src/fairseq2/assets/cards/models/qwen.yaml index fd1dce967..624b2152d 100644 --- a/src/fairseq2/assets/cards/models/qwen.yaml +++ b/src/fairseq2/assets/cards/models/qwen.yaml @@ -4,6 +4,21 @@ # This source code is licensed under the BSD-style license found in the # LICENSE file in the root directory of this source tree. +--- + +name: qwen25_3b_instruct +model_family: qwen +model_arch: qwen25_3b +model_config: + _set_: + max_seq_len: 8192 +checkpoint: "hg://qwen/qwen2.5-3b-instruct" +tokenizer: "hg://qwen/qwen2.5-3b-instruct" +tokenizer_family: qwen +use_im_end: true + +--- + name: qwen25_7b model_family: qwen model_arch: qwen25_7b From f76fb9f0c097f467b373743e523ef03dbd654113 Mon Sep 17 00:00:00 2001 From: jacklanchantin Date: Fri, 25 Jul 2025 00:59:51 +0000 Subject: [PATCH 3/4] increase max seq len --- src/fairseq2/assets/cards/models/qwen.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/fairseq2/assets/cards/models/qwen.yaml b/src/fairseq2/assets/cards/models/qwen.yaml index 624b2152d..d6590480f 100644 --- a/src/fairseq2/assets/cards/models/qwen.yaml +++ b/src/fairseq2/assets/cards/models/qwen.yaml @@ -11,7 +11,7 @@ model_family: qwen model_arch: qwen25_3b model_config: _set_: - max_seq_len: 8192 + max_seq_len: 32768 checkpoint: "hg://qwen/qwen2.5-3b-instruct" tokenizer: "hg://qwen/qwen2.5-3b-instruct" tokenizer_family: qwen From eb757e199de3e7d7802a73e28e7cd2376881fc85 Mon Sep 17 00:00:00 2001 From: jacklanchantin Date: Fri, 25 Jul 2025 01:13:29 +0000 Subject: [PATCH 4/4] revert yaml --- src/fairseq2/assets/cards/models/qwen.yaml | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/src/fairseq2/assets/cards/models/qwen.yaml b/src/fairseq2/assets/cards/models/qwen.yaml index d6590480f..fd1dce967 100644 --- a/src/fairseq2/assets/cards/models/qwen.yaml +++ b/src/fairseq2/assets/cards/models/qwen.yaml @@ -4,21 +4,6 @@ # This source code is licensed under the BSD-style license found in the # LICENSE file in the root directory of this source tree. ---- - -name: qwen25_3b_instruct -model_family: qwen -model_arch: qwen25_3b -model_config: - _set_: - max_seq_len: 32768 -checkpoint: "hg://qwen/qwen2.5-3b-instruct" -tokenizer: "hg://qwen/qwen2.5-3b-instruct" -tokenizer_family: qwen -use_im_end: true - ---- - name: qwen25_7b model_family: qwen model_arch: qwen25_7b