Commit 288d864
Fix weak external symbol leakage (#4758)
Summary:
This PR enforces hidden visibility for internal templates for the macOS/Linux builds. By doing so we can eliminate the weak external symbol leakage that causes linker warnings and instability in complex environments like Flask/Conda #2167.
Verified that the visibility was changed for constructors and destructors via nm -m command.
Pull Request resolved: #4758
Reviewed By: alibeklfc
Differential Revision: D90891541
Pulled By: junjieqi
fbshipit-source-id: f350c2c63745d2f005138be9eccdcaf9b2d4d0f81 parent d05801a commit 288d864
1 file changed
Lines changed: 7 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
114 | 114 | | |
115 | 115 | | |
116 | 116 | | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
117 | 124 | | |
118 | 125 | | |
119 | 126 | | |
| |||
0 commit comments