Strengthen roundtrip tests by doing serialization after deserialization#4851
Closed
sh00s wants to merge 1 commit into
Closed
Strengthen roundtrip tests by doing serialization after deserialization#4851sh00s wants to merge 1 commit into
sh00s wants to merge 1 commit into
Conversation
Summary: Roundtrip tests only test serialize -> deserialize. They should also test the deserialize -> serialize sequence. Reviewed By: mdouze Differential Revision: D93678044
Contributor
Contributor
|
This pull request has been merged in db5aef2. |
dimitraseferiadi
pushed a commit
to dimitraseferiadi/SuCo
that referenced
this pull request
Mar 8, 2026
…on (facebookresearch#4851) Summary: Pull Request resolved: facebookresearch#4851 Roundtrip tests only test serialize -> deserialize. They should also test the deserialize -> serialize sequence. Reviewed By: mdouze Differential Revision: D93678044 fbshipit-source-id: 1503b5b954d49df509d9f785d35911ade989290e
dimitraseferiadi
pushed a commit
to dimitraseferiadi/SuCo
that referenced
this pull request
Mar 16, 2026
…on (facebookresearch#4851) Summary: Pull Request resolved: facebookresearch#4851 Roundtrip tests only test serialize -> deserialize. They should also test the deserialize -> serialize sequence. Reviewed By: mdouze Differential Revision: D93678044 fbshipit-source-id: 1503b5b954d49df509d9f785d35911ade989290e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Roundtrip tests only test serialize -> deserialize. They should also test the deserialize -> serialize sequence.
Reviewed By: mdouze
Differential Revision: D93678044