Add sentinels to index format enums.#4907
Closed
scsiguy wants to merge 2 commits into
Closed
Conversation
…ebookresearch#4902) Summary: When enabled, throw a FAISS exception when index deserialization loops driven by read data fields (nlist, nsplits, VT chain length, nhash, etc.) exceed a configured limit. This can be set by input validation tests to prevent wasting time on pathological, OOM inducting, inputs. Default: 0 (no limit). Differential Revision: D96016580
Summary: The sentinels will be used to detect drift between index formats and test coverage. The MetricType enum is handled differently since it is discontiguous. The metric_type_count() method computes the count of enum entries which is likely to change should additional types be added. Reviewed By: mnorris11 Differential Revision: D96032245
Contributor
Contributor
|
This pull request has been merged in 0fcba22. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The sentinels will be used to detect drift between index formats
and test coverage.
The MetricType enum is handled differently since it is discontiguous.
The metric_type_count() method computes the count of enum entries which
is likely to change should additional types be added.
Reviewed By: mnorris11
Differential Revision: D96032245