Skip to content

Open SIFT demo data in binary mode #5213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
massy-o wants to merge 3 commits into from
+1 −1
Closed

Open SIFT demo data in binary mode #5213

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b7b91ea
Open SIFT demo data in binary mode
massy-o May 14, 2026
e853fb3
Trigger CLA check
massy-o May 14, 2026
bd6d83b
Merge branch 'main' into codex/open-sift-demo-binary
alibeklfc May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion demos/demo_sift1M.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
*****************************************************/

float* fvecs_read(const char* fname, size_t* d_out, size_t* n_out) {
FILE* f = fopen(fname, "r");
FILE* f = fopen(fname, "rb");
Copy link
Copy Markdown
Contributor Author

@massy-o massy-o May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review: The demo treats .fvecs/.ivecs files as fixed-width binary records, so rb avoids platform text-mode translation before the size and fread assertions run.

if (!f) {
fprintf(stderr, "could not open %s\n", fname);
perror("");
Expand Down
Loading