Commit 1df99e2
Delete deletion-eligible test_kahan_summation_cpu
Summary:
Oncall test cleanup for the `stl_multimodal` rotation. TestX flags
`TestAnyPrecisionOptimizer.test_kahan_summation_cpu` (test IDs
`281475243659032` and `281475243855546`) as eligible for deletion — it sits in
`DISABLED_FAILING` trunk state with an open `FAILURE` issue, well past the
60-day zero-value threshold.
The test hard-coded four bfloat16 compensation-buffer tensors captured from a
seeded two-step optimizer run and compared them at `atol=1e-4`. At bfloat16
precision those buffers hold values near `1e-5`, so the assertion tolerance is
wider than the quantities being checked and the test was pinning RNG output
rather than Kahan-summation correctness. Deleting is the right call here
rather than re-recording the golden buffers.
`test_kahan_summation_gpu` is left in place: it is `gpu_test()`-gated, was not
flagged, and still covers the same `use_kahan_summation=True` path.
`_test_adam_equivalence`, `test_adam_equivalence_cpu`, `_test_bfloat16_states`,
and `test_bfloat16_states_cpu` continue to cover `AnyPrecisionAdamW` on CPU.
Differential Revision: D1143970641 parent 94405b0 commit 1df99e2
1 file changed
Lines changed: 0 additions & 114 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
136 | 136 | | |
137 | 137 | | |
138 | 138 | | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | | - | |
153 | | - | |
154 | | - | |
155 | | - | |
156 | | - | |
157 | | - | |
158 | | - | |
159 | | - | |
160 | | - | |
161 | | - | |
162 | | - | |
163 | | - | |
164 | | - | |
165 | | - | |
166 | | - | |
167 | | - | |
168 | | - | |
169 | | - | |
170 | | - | |
171 | | - | |
172 | | - | |
173 | | - | |
174 | | - | |
175 | | - | |
176 | | - | |
177 | | - | |
178 | | - | |
179 | | - | |
180 | | - | |
181 | | - | |
182 | | - | |
183 | | - | |
184 | | - | |
185 | | - | |
186 | | - | |
187 | | - | |
188 | | - | |
189 | | - | |
190 | | - | |
191 | | - | |
192 | | - | |
193 | | - | |
194 | | - | |
195 | | - | |
196 | | - | |
197 | | - | |
198 | | - | |
199 | | - | |
200 | | - | |
201 | | - | |
202 | | - | |
203 | | - | |
204 | | - | |
205 | | - | |
206 | | - | |
207 | | - | |
208 | | - | |
209 | | - | |
210 | | - | |
211 | | - | |
212 | | - | |
213 | | - | |
214 | | - | |
215 | | - | |
216 | | - | |
217 | | - | |
218 | | - | |
219 | | - | |
220 | | - | |
221 | | - | |
222 | | - | |
223 | | - | |
224 | | - | |
225 | | - | |
226 | | - | |
227 | | - | |
228 | | - | |
229 | | - | |
230 | | - | |
231 | | - | |
232 | | - | |
233 | | - | |
234 | | - | |
235 | | - | |
236 | | - | |
237 | | - | |
238 | | - | |
239 | | - | |
240 | | - | |
241 | | - | |
242 | | - | |
243 | | - | |
244 | | - | |
245 | | - | |
246 | | - | |
247 | | - | |
248 | | - | |
249 | | - | |
250 | | - | |
251 | | - | |
252 | | - | |
253 | 139 | | |
254 | 140 | | |
255 | 141 | | |
| |||
0 commit comments