Commit 7177a8a
Revert AI-codemod integration test for AdvancedFrameFilterGaussian::Comfort
Summary:
This reverts the AI-codemod diff D111031148 ([AI Codemod][DevmateRLSoftwareCoverageCppIntegrationTestGenerator]), which added `AdvancedFrameFilterGaussianComfortIntegrationTest.cpp` and its `BUCK` registration.
The generated suite includes `InPlaceEvenFilterSizeIsRejected` and `OutOfPlaceEvenFilterSizeIsRejected`, which call `AdvancedFrameFilterGaussian::Comfort::filter` with an even `filterSize` and `EXPECT_FALSE`. An even `filterSize` is a documented precondition violation, not a supported input: every function in the Gaussian/Separable/Mean filter family documents `filterSize` as `"[1, infinity), must be odd"`, and the `void`-returning template workers `ocean_assert(filterSize % 2u == 1u)` with no graceful path. The `if (filterSize % 2u != 1u) return false;` in the Comfort wrapper is Ocean's standard release-mode safety net (assert in debug, degrade in release), not a promised contract. In the `linux_x86_64_static_debug` build the assert at `AdvancedFrameFilterGaussian.cpp:22`/`:63` therefore correctly fires and aborts because the tests feed invalid input.
The production code and its precondition asserts are correct and are intentionally left untouched. Because the generator does not respect the documented `must be odd` constraints, the remaining tests it produced are equally unvetted, so the whole generated artifact is reverted rather than partially patched. Legitimate coverage for `AdvancedFrameFilterGaussian::Comfort`, if wanted, should be re-added as hand-written tests that respect the contract (tracked separately).
___
Differential Revision: D111216529
fbshipit-source-id: 0aa220940b31b8b392a064ab909696d6554c2d711 parent a2edf42 commit 7177a8a
1 file changed
Lines changed: 0 additions & 338 deletions
Lines changed: 0 additions & 338 deletions
This file was deleted.
0 commit comments