Ocean: Filter by endpoint address on the SuperSpeed companion-descriptor path too

Summary:
Inside the per-endpoint loop of `determineIsochronousTransferLayout()` only the fallback branch checked the endpoint address. The SuperSpeed branch assigned `endpointPacketSize = endpointCompanionDescriptor->wBytesPerInterval` for whichever endpoint it was looking at, with no address check and no `break`.

On a SuperSpeed link every endpoint carries a companion descriptor, so that branch is the one taken for all of them and the loop simply kept overwriting the value. The packet size therefore came from the *last* endpoint of the altsetting rather than from the one whose `bEndpointAddress` matches the requested `endpointAddress`, which the header documents as "The address of the endpoint on which the transfer will happen".

The address filter is now applied once, ahead of both branches, and the loop breaks after either has determined the size. With the usual single-endpoint UVC altsetting nothing changes, which is why this stayed unnoticed; it matters when a streaming altsetting also exposes a still-image endpoint.

___

Differential Revision: D115344628

fbshipit-source-id: 41b3ec4272c51f2322bec198b86325f3b8c56d82

Author: janherlingmeta

impl/ocean/system/usb/Device.cpp

@@ -549,6 +549,13 @@ int Device::determineIsochronousTransferLayout(libusb_context* usbContext, const
 		{
 			const libusb_endpoint_descriptor& endpointDescriptor = altSetting.endpoint[endpointIndex];
 
+			// a SuperSpeed altsetting can expose several endpoints and each of them carries a companion descriptor, so the address has to be checked for both variants below
+
+			if (endpointDescriptor.bEndpointAddress != endpointAddress)
+			{
+				continue;
+			}
+
 			libusb_ss_endpoint_companion_descriptor* endpointCompanionDescriptor = nullptr;
 			if (libusb_get_ss_endpoint_companion_descriptor(usbContext, &endpointDescriptor, &endpointCompanionDescriptor) == LIBUSB_SUCCESS)
 			{
@@ -559,22 +566,20 @@ int Device::determineIsochronousTransferLayout(libusb_context* usbContext, const
 			}
 			else
 			{
-				if (endpointDescriptor.bEndpointAddress == endpointAddress)
-				{
-					const uint16_t wMaxPacketSize = endpointDescriptor.wMaxPacketSize;
-					ocean_assert((wMaxPacketSize & 0xE000u) == 0u); // the upper 3 bits should always be zero, otherwise we may have USB 3.0
+				const uint16_t wMaxPacketSize = endpointDescriptor.wMaxPacketSize;
+				ocean_assert((wMaxPacketSize & 0xE000u) == 0u); // the upper 3 bits should always be zero, otherwise we may have USB 3.0
 
-					const uint16_t sizePerTransaction = wMaxPacketSize & 0x7FFu; // the lower 11 bits provide the actual size of the transaction
+				const uint16_t sizePerTransaction = wMaxPacketSize & 0x7FFu; // the lower 11 bits provide the actual size of the transaction
 
-					const uint16_t additionalTransactions = (wMaxPacketSize >> 11u) & 0b11u; // the next two bytes give the number of additional transactions
-					ocean_assert(additionalTransactions <= 2u);
+				const uint16_t additionalTransactions = (wMaxPacketSize >> 11u) & 0b11u; // the next two bytes give the number of additional transactions
+				ocean_assert(additionalTransactions <= 2u);
 
-					const uint16_t overallTransactions = additionalTransactions + 1u;
+				const uint16_t overallTransactions = additionalTransactions + 1u;
 
-					endpointPacketSize = uint32_t(sizePerTransaction) * uint32_t(overallTransactions);
-					break;
-				}
+				endpointPacketSize = uint32_t(sizePerTransaction) * uint32_t(overallTransactions);
 			}
+
+			break;
 		}
 
 		if (endpointPacketSize >= maxPayloadTransferSize)