Skip to content

Commit 1341705

Browse files
generatedunixname1587093422349604meta-codesync[bot]
authored andcommitted
Fix CQS signal modernize-use-emplace in arvr/projects/ariane/aria_research_kit
Differential Revision: D92260851 fbshipit-source-id: 2e1d34854f1cdfcde4d8b11754dc3e7027bf98af
1 parent f3d4812 commit 1341705

4 files changed

Lines changed: 7 additions & 9 deletions

File tree

core/data_provider/test/VrsDataProviderGetDataByTimeTest.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -181,8 +181,7 @@ TEST(VrsDataProvider, multiThreadGetDataByTimeNsInBound) {
181181
const auto streamIds = provider->getAllStreams();
182182
std::vector<std::thread> threads;
183183
for (const auto streamId : streamIds) {
184-
threads.emplace_back(
185-
std::thread([&provider, streamId]() { checkInBound(provider, streamId); }));
184+
threads.emplace_back([&provider, streamId]() { checkInBound(provider, streamId); });
186185
}
187186

188187
for (auto& thread : threads) {
@@ -199,8 +198,7 @@ TEST(VrsDataProvider, multiThreadGetDataByTimeNsOutOfBound) {
199198
const auto streamIds = provider->getAllStreams();
200199
std::vector<std::thread> threads;
201200
for (const auto streamId : streamIds) {
202-
threads.emplace_back(
203-
std::thread([&provider, streamId]() { checkOutOfBound(provider, streamId); }));
201+
threads.emplace_back([&provider, streamId]() { checkOutOfBound(provider, streamId); });
204202
}
205203

206204
for (auto& thread : threads) {

examples/Gen1/cpp_samples/pointcloud_colorization/RGBPointCloudColorizer.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ class RGBPointCloudColorizer : public PointCloudColorizer {
194194
for (const auto& pt : globalPointCloud_) {
195195
if (accumulatorCount_.count(pt.uid) == 0) {
196196
// If point has been unseen set a default color
197-
colors.push_back(Eigen::Vector3f(255, 0, 0) / 255.f);
197+
colors.emplace_back(Eigen::Vector3f(255, 0, 0) / 255.f);
198198
continue;
199199
}
200200
colors.push_back(colorAccumulator_.at(pt.uid));

tools/mps_visualization/EyeGazeAriaViewer.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -195,8 +195,8 @@ void EyeGazeAriaViewer::addEtPlot() {
195195
logEyeGaze_ = std::make_shared<pangolin::DataLog>();
196196
std::vector<std::string> labels = {"Generalized gaze yaw [rad]", "Generalized gaze pitch [rad]"};
197197
if (calibratedEyeGazesVisData_) {
198-
labels.push_back("Calibrated gaze yaw [rad]");
199-
labels.push_back("Calibrated gaze pitch [rad]");
198+
labels.emplace_back("Calibrated gaze yaw [rad]");
199+
labels.emplace_back("Calibrated gaze pitch [rad]");
200200
}
201201
logEyeGaze_->SetLabels(labels);
202202
eyeGazePlotter_ = std::make_shared<pangolin::Plotter>(

tools/mps_visualization/MPS3DSceneViewer.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ int mps3dSceneViewerCli(int argc, const char** argv) {
7575
std::vector<Eigen::Vector3f> openTrajPoints;
7676
openTrajPoints.reserve(openTraj.size());
7777
for (const auto& pose : openTraj) {
78-
openTrajPoints.push_back(pose.T_odometry_device.translation().cast<float>());
78+
openTrajPoints.emplace_back(pose.T_odometry_device.translation().cast<float>());
7979
}
8080
fullTrajs_world.push_back(std::move(openTrajPoints));
8181
}
@@ -92,7 +92,7 @@ int mps3dSceneViewerCli(int argc, const char** argv) {
9292
std::vector<Eigen::Vector3f> closedTrajPoints;
9393
closedTrajPoints.reserve(closedTraj.size());
9494
for (const auto& pose : closedTraj) {
95-
closedTrajPoints.push_back(pose.T_world_device.translation().cast<float>());
95+
closedTrajPoints.emplace_back(pose.T_world_device.translation().cast<float>());
9696
allWorldFrameUids.insert(pose.graphUid);
9797
}
9898
fullTrajs_world.push_back(std::move(closedTrajPoints));

0 commit comments

Comments
 (0)