Commit 27229bc
{BugFix} Core - Fix NaN comparison failures in data provider test helpers
Summary:
Explanation:
Test helper compare functions did not handle NaN and uninitialized values correctly, causing deterministic and flaky test failures in VrsDataProvider.multiThreadGetDataByIndex and VrsDataProvider.getDataByIndex.
Two issues fixed:
1. Internal CompareDataHelper: EXPECT_EQ(NaN, NaN) always fails per IEEE 754. AriaGen1 test VRS data has NaN in image temperature_deg_c field (sensor unavailable). Replaced with NaN-safe comparison.
2. OSS CompareDataHelper: EyeGaze spatial_gaze_point_in_cpf and combined_gaze_origin_in_cpf are Eigen::Vector3f with no default initialization. When VRS validity flags are false, the vectors contain uninitialized memory. Moved isApprox checks behind validity flag guards.
Reproducibility:
Both single-threaded (getDataByIndex) and multi-threaded (multiThreadGetDataByIndex) tests now pass on all three test sequences (AriaGen1, AriaGen2, AriaGen2PFrame).
___
overriding_review_checks_triggers_an_audit_and_retroactive_review
Oncall Short Name: nebula_functionality_sutdy
landed-with-radar-review
Differential Revision: D104139932
fbshipit-source-id: 19d34893185586189efb09e66946220791fdf3491 parent 77973a1 commit 27229bc
1 file changed
Lines changed: 8 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
433 | 433 | | |
434 | 434 | | |
435 | 435 | | |
436 | | - | |
437 | | - | |
438 | | - | |
439 | | - | |
440 | 436 | | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
441 | 441 | | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
442 | 446 | | |
443 | 447 | | |
444 | 448 | | |
| |||
0 commit comments