Fix CQS signal modernize-use-integer-sign-comparison in arvr/projects/ariane/aria_research_kit [A] (#371)

Summary: Pull Request resolved: #371

Reviewed By: PiotrBrzyski

Differential Revision: D111912610

fbshipit-source-id: e2c1c8b582e25b6f6bcb1382aa23f093c69b9609

Author: generatedunixname1587093422349604

core/calibration/camera_projections/FisheyeRadTanThinPrism.h

@@ -18,6 +18,8 @@
 
 #include <calibration/camera_projections/Common.h>
 
+#include <utility>
+
 namespace projectaria::tools::calibration {
 
 // Model for fisheye cameras with radial, tangential, and thin-prism distortion.
@@ -155,7 +157,7 @@ class FisheyeRadTanThinPrism {
         } else {
           T dthD_dth = static_cast<T>(1.0);
           T theta2i = thetaSq;
-          for (size_t i = 0; i < numK; ++i) {
+          for (size_t i = 0; std::cmp_less(i, numK); ++i) {
             dthD_dth += T(2 * i + 3) * params[startK + i] * theta2i;
             theta2i *= thetaSq;
           }
@@ -198,7 +200,7 @@ class FisheyeRadTanThinPrism {
             temp = params.template head<2>().cwiseProduct(th_divr * (duvDistorted_dxryr * ab));
           }
           T theta2i = thetaSq;
-          for (size_t i = 0; i < numK; ++i) {
+          for (size_t i = 0; std::cmp_less(i, numK); ++i) {
             d_param->col(startK + i) = theta2i * temp;
             theta2i *= thetaSq;
           }

core/data_provider/players/HandPosePlayer.cpp

@@ -18,6 +18,7 @@
 
 #include <fmt/format.h>
 #include <cmath>
+#include <utility>
 
 #include <data_provider/players/DataPlayerUtils.h>
 #include <mps/HandTracking.h>
@@ -64,7 +65,7 @@ std::optional<HandTrackingResult::OneSide> populateOneSideHand(
     fmt::print("Missing handLandmarks3d_DeviceMeterXyz in hand pose data layout!");
     return {};
   }
-  for (int landmarkIdx = 0; landmarkIdx < kHtLandmarksCount; ++landmarkIdx) {
+  for (int landmarkIdx = 0; std::cmp_less(landmarkIdx, kHtLandmarksCount); ++landmarkIdx) {
     oneSide.landmarkPositions_device[landmarkIdx] =
         mapToEigenVector<float, double, 3>(vrsLandmarks3d.at(landmarkIdx));
   }

core/data_provider/test/VrsDataProviderGetDataByIndexTest.cpp

@@ -19,6 +19,8 @@
 #include <gmock/gmock-matchers.h>
 #include <gtest/gtest.h>
 
+#include <utility>
+
 using namespace projectaria::tools::data_provider;
 using namespace projectaria::tools::mps;
 using namespace projectaria::tools::data_provider::test;
@@ -38,7 +40,7 @@ void checkGetDataByIndex(
   size_t numData = provider->getNumData(streamId);
   int lastDeviceTime = -1;
 
-  for (int f = 0; f < numData; ++f) {
+  for (int f = 0; std::cmp_less(f, numData); ++f) {
     const auto sensorData = provider->getSensorDataByIndex(streamId, f);
     EXPECT_EQ(sensorData.sensorDataType(), provider->getSensorDataType(streamId));
 

core/gen2_mp_csv_exporter/file_io/MpvCsvWriter.cpp

@@ -17,6 +17,7 @@
 #include <fmt/format.h>
 #include <gen2_mp_csv_exporter/file_io/MpvCsvWriter.h>
 #include <iostream>
+#include <utility>
 
 namespace {
 const std::string kEyeGazeCsvHeader =
@@ -38,7 +39,8 @@ const std::string kVioHighFreqCsvHeader =
 std::string getHandPoseCsvHeader() {
   std::string header = "tracking_timestamp_us,left_tracking_confidence";
   // Left landmarks
-  for (int iLandmark = 0; iLandmark < projectaria::tools::mps::kNumHandLandmarks; ++iLandmark) {
+  for (int iLandmark = 0; std::cmp_less(iLandmark, projectaria::tools::mps::kNumHandLandmarks);
+       ++iLandmark) {
     header += fmt::format(
         ",tx_left_landmark_{}_device,ty_left_landmark_{}_device,tz_left_landmark_{}_device",
         iLandmark,
@@ -47,7 +49,8 @@ std::string getHandPoseCsvHeader() {
   }
   header += ",right_tracking_confidence";
   // Right landmarks
-  for (int iLandmark = 0; iLandmark < projectaria::tools::mps::kNumHandLandmarks; ++iLandmark) {
+  for (int iLandmark = 0; std::cmp_less(iLandmark, projectaria::tools::mps::kNumHandLandmarks);
+       ++iLandmark) {
     header += fmt::format(
         ",tx_right_landmark_{}_device,ty_right_landmark_{}_device,tz_right_landmark_{}_device",
         iLandmark,