Commit 91a93ae
{BugFix} Packaging - Ship viewer_projects and align rerun-notebook pin
Summary:
Explanation:
The `viewer_projects_adt`, `viewer_projects_ase` and `viewer_projects_aea`
console scripts have been dead in every Gen2 wheel. Two independent packaging
defects stacked:
1. The `entry_points` still pointed at `projectaria_tools.utils.viewer_projects_*`,
a path left over from the Gen1 layout. In Gen2 these modules live under
`projectaria_tools/tools/viewer_projects/`. `entry_points` is unvalidated
metadata, so `pip` happily generated three launcher scripts that raise
`ModuleNotFoundError` on the first line.
2. `projectaria_tools/tools/viewer_projects/` had no `__init__.py`, so
`find_packages()` skipped it and the three modules were never placed in the
wheel at all. It was the only directory under `tools/` missing the marker.
Both are fixed: the entry points now resolve to
`projectaria_tools.tools.viewer_projects.viewer_projects_*`, and the package
marker is added so the modules ship.
Separately, `rerun-notebook` was pinned to `0.26.2` while `rerun-sdk` moved to
`0.33.0`. `rerun-notebook` is an optional dependency of `rerun-sdk`, exactly
pinned by its `notebook` extra, and hand-copying that pin into
`install_requires` gave the two packages independent version numbers that were
free to drift apart. They did, and `pip` had no constraint linking them, so the
mismatch resolved silently.
Rather than correct the stale number, the direct `rerun-notebook` requirement is
replaced by `rerun-sdk[notebook]==0.33.0`. There is now a single version to bump
and the notebook widget cannot desync from the SDK again. `jupyter` is already
an unconditional dependency, so this adds no weight for non-notebook users.
___
Differential Revision: D115607424
fbshipit-source-id: bf4c86777bb64f6a9f8cad5f263f3e71382ae22b1 parent e59f0eb commit 91a93ae
3 files changed
Lines changed: 20 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
189 | 189 | | |
190 | 190 | | |
191 | 191 | | |
192 | | - | |
193 | | - | |
| 192 | + | |
194 | 193 | | |
195 | 194 | | |
196 | 195 | | |
| |||
200 | 199 | | |
201 | 200 | | |
202 | 201 | | |
203 | | - | |
204 | | - | |
205 | | - | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
206 | 205 | | |
207 | 206 | | |
208 | 207 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
0 commit comments