Del redundant-static-def in arvr/projects/ariane/aria_research_kit/projectaria_tools/core/image/DefaultImageValTraits.h +2

Summary:
LLVM has a warning `-Wdeprecated-redundant-constexpr-static-def` which raises the warning:

> warning: out-of-line definition of constexpr static data member is redundant in C++17 and is deprecated

Since we are now on C++20, we can remove the out-of-line definition of constexpr static data members. This diff does so.

 - If you approve of this diff, please use the "Accept & Ship" button :-)

Reviewed By: meyering

Differential Revision: D78494011

fbshipit-source-id: 5548b4ad2a98d40752db4397f4b4e684e403e0ff

Author: r-barnes

core/image/DefaultImageValTraits.h

@@ -30,9 +30,6 @@ struct DefaultImageValTraits {
   static const size_t channel = 1;
 };
 
-template <class T, class Enable>
-constexpr int DefaultImageValTraits<T, Enable>::maxValue;
-
 template <class T>
 struct DefaultImageValTraits<T, typename std::enable_if<std::is_integral<T>::value>::type> {
   static constexpr int maxValue = (sizeof(T) >= sizeof(int))

core/image/Image.h

@@ -386,9 +386,6 @@ PROJECTARIA_HOST_DEVICE inline T Image<T, MaxValue>::operator()(P u, P v) const
   }
 }
 
-template <typename T, int MaxValue>
-constexpr int Image<T, MaxValue>::maxValue;
-
 static_assert(Image<uint8_t>::maxValue == 255, "Compile time sanity check");
 static_assert(Image<float>::maxValue == 1, "Compile time sanity check");
 static_assert(Image<uint16_t, 1023>::maxValue == 1023, "Compile time sanity check");