Skip to content

Commit a8da262

Browse files
YLouWashUfacebook-github-bot
authored andcommitted
{Build} Core - Bump VRS pin for XPRS NVDEC symbols
Summary: Explanation: `projectaria_tools` builds VRS via `FetchContent` with a pinned `GIT_TAG` in `cmake/Setup3rdParty.cmake`. The previous pin (`125db715`, main Jun 26, 2026) predates the XPRS NVDEC changes, so `core/python/XprsPyBind.h` references `xprs::hasCudaSupport` while the fetched VRS does not declare it. The external wheel build fails with: ``` core/python/XprsPyBind.h:152:14: error: no member named 'hasCudaSupport' in namespace 'xprs' &xprs::hasCudaSupport, ``` This bumps the VRS pin to `15d40a41b107f7923f6368b93109919cd49bb3c9`, which carries the NVDEC symbols (`xprs::hasCudaSupport` plus the `ENABLE_NVCODEC` plumbing), unblocking NVDEC in the wheel build. Reproducibility: `arc f` and `arc lint` pass on the changed file. The pinned commit resolves in `facebookresearch/vrs`, so `FetchContent` can fetch it and the wheel build can compile `XprsPyBind.h`. Differential Revision: D114445000
1 parent 0126700 commit a8da262

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

cmake/Setup3rdParty.cmake

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,14 @@ FetchContent_Declare(
3737
)
3838

3939
# Fetch VRS lib with XPRS support
40+
# The pin must carry the XPRS NVDEC symbols (xprs::hasCudaSupport plus the
41+
# ENABLE_NVCODEC plumbing); the previous pin (125db715) predates them, so
42+
# XprsPyBind.h fails to compile with "no member named 'hasCudaSupport' in
43+
# namespace 'xprs'".
4044
FetchContent_Declare(
4145
vrs
4246
GIT_REPOSITORY https://github.com/facebookresearch/vrs.git
43-
GIT_TAG 125db715b73e2768723defcb88ccb755fabcd43d # main Jun 26, 2026.
47+
GIT_TAG 15d40a41b107f7923f6368b93109919cd49bb3c9 # XPRS NVDEC support.
4448
)
4549
# Override config for vrs
4650
option(UNIT_TESTS OFF)

0 commit comments

Comments
 (0)