Commit e4437ac
{BugFix} Core - Recognize Aria Gen2 battery stream (502-1) in the VRS data provider
Summary:
Explanation:
Aria Gen2 recordings contain a Battery stream (`RecordableTypeId` 502, flavor `device/oatmeal`), but the VRS data provider did not recognize it. `getSensorDataType` had no `BatteryRecordableClass` entry, so the stream was dropped with `Fail to activate streamId 502-1`; and the Gen2 `StreamIdLabelMapper` had no `502-1` entry, so it logged `stream id 502-1 not found in Aria Device Model`. This adds the missing `RecordableTypeId` -> `SensorDataType::BatteryStatus` mapping (routing 502 to the already-present `BatteryStatusPlayer` case in `addPlayers`) and the `502-1` -> `battery-status` label. Battery telemetry now loads instead of being dropped as an unrecognized stream. This does not affect the separate VRS Health Check `device_info`/proximity validation.
Reproducibility:
Open a Gen2 `profile8` recording with `createVrsDataProvider`; the `502-1` stream is now activated and labeled `battery-status` rather than emitting the two warnings above.
___
Differential Revision: D113469938
fbshipit-source-id: e7564d5cf530aacffa0e75a3a462ae13cb51c8d91 parent 5c453b9 commit e4437ac
3 files changed
Lines changed: 10 additions & 0 deletions
File tree
- core/data_provider
- test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
108 | 108 | | |
109 | 109 | | |
110 | 110 | | |
| 111 | + | |
111 | 112 | | |
112 | 113 | | |
113 | 114 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
79 | 82 | | |
80 | 83 | | |
81 | 84 | | |
| |||
Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
85 | 91 | | |
0 commit comments