Open
Description
Reading through the documentation for se3_log_map
, I was under the impression that eps
and cos_bound
were important for numerical stability:
pytorch3d/pytorch3d/transforms/se3.py
Lines 142 to 147 in 43cd681
However, following #1609 and 292acc7 it appeared that eps
and cos_bound
are only retained for backwards compatibility in so3_log_map
(Note the o
instead of e
). This is made clear in the corresponding documentation:
pytorch3d/pytorch3d/transforms/so3.py
Lines 184 to 185 in 43cd681
Now, given that se3_log_map
calls so3_log_map
,
pytorch3d/pytorch3d/transforms/se3.py
Line 173 in 43cd681
I believe the deprecation of
eps
and cos_bound
should also be highlighted in teh documentation of se3_log_map
.Metadata
Metadata
Assignees
Labels
No labels