Skip to content

Commit b7bdbdd

Browse files
r-barnesfacebook-github-bot
authored andcommitted
fbcode/libspdl, fbcode/spdl/io/lib: add missing <fmt/format.h> includes for fmt 12.2.0
Summary: fmt::format() moved out of fmt/core.h in fmt 12.2.0; these files only included fmt/core.h (or no fmt header at all) and relied on fmt::format transitively/implicitly. Add the explicit <fmt/format.h> include across the libspdl/spdl core and cuda subtrees, found via a subsystem sweep after fbcode//spdl/io/lib:_spdl_ffmpeg failed to build. Differential Revision: D112806772
1 parent 4fc5ed8 commit b7bdbdd

26 files changed

Lines changed: 27 additions & 0 deletions

src/libspdl/core/adaptor/bytes.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
#include "libspdl/core/detail/ffmpeg/ctx_utils.h"
1212

1313
#include <fmt/core.h>
14+
#include <fmt/format.h>
1415
#include <glog/logging.h>
1516

1617
extern "C" {

src/libspdl/core/detail/ffmpeg/compat.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
#pragma once
1010

1111
#include <fmt/core.h>
12+
#include <fmt/format.h>
1213

1314
extern "C" {
1415
#include <libavcodec/avcodec.h>

src/libspdl/core/detail/ffmpeg/decoder.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
#include "libspdl/core/detail/ffmpeg/logging.h"
1616
#include "libspdl/core/detail/tracing.h"
1717

18+
#include <fmt/format.h>
1819
#include <glog/logging.h>
1920

2021
namespace spdl::core::detail {

src/libspdl/core/detail/ffmpeg/logging.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
#include "libspdl/core/detail/logging.h"
1212

1313
#include <fmt/core.h>
14+
#include <fmt/format.h>
1415

1516
extern "C" {
1617
#include <libavutil/attributes.h>

src/libspdl/core/detail/ffmpeg/muxer.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
#include <fmt/core.h>
1818
#include <fmt/format.h>
1919

20+
#include <cstring>
2021
#include <filesystem>
2122
#include <set>
2223

src/libspdl/core/detail/ffmpeg/wrappers.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ OptionDict parse_dict(const AVDictionary* metadata) {
9797
#ifdef SPDL_DEBUG_REFCOUNT
9898

9999
#include <fmt/core.h>
100+
#include <fmt/format.h>
100101
#include <glog/logging.h>
101102

102103
extern "C" {

src/libspdl/core/detail/logging.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
#include "libspdl/core/detail/logging.h"
1010

1111
#include <fmt/core.h>
12+
#include <fmt/format.h>
1213

1314
namespace spdl::core::detail {
1415

src/libspdl/core/frames.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
#include "libspdl/core/detail/ffmpeg/wrappers.h"
1818
#include "libspdl/core/detail/tracing.h"
1919

20+
#include <fmt/format.h>
21+
2022
#include <algorithm>
2123
#include <cassert>
2224

src/libspdl/core/muxer.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
#include "libspdl/core/detail/logging.h"
1313

1414
#include <fmt/core.h>
15+
#include <fmt/format.h>
1516

1617
namespace spdl::core {
1718

src/libspdl/core/packets.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
#include "libspdl/core/detail/tracing.h"
1717

1818
#include <fmt/core.h>
19+
#include <fmt/format.h>
1920

2021
#include <algorithm>
2122
#include <cassert>

0 commit comments

Comments
 (0)