Commit 69e3779
committed
Correct the /config path validation comment
The comment claimed set_g_cred_path()'s validation kept the endpoint from
doubling as a probe for arbitrary filesystem paths. That is backwards: the
validation constrains the file's kind (a readable .json) but not its
location, so the valid/invalid response is an existence oracle for readable
JSON files anywhere on disk.
Record what is actually true, why the path is left unconstrained (service
account credentials normally live outside --data-root), and why the oracle is
accepted rather than fixed (localhost-default bind plus XSRF). CodeQL alert
#15 (py/path-injection) is dismissed on the same rationale.1 parent 7785dea commit 69e3779
1 file changed
Lines changed: 13 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
287 | 287 | | |
288 | 288 | | |
289 | 289 | | |
290 | | - | |
291 | | - | |
292 | | - | |
293 | | - | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
294 | 303 | | |
295 | 304 | | |
296 | 305 | | |
| |||
0 commit comments