Apply linter suggestions

Summary: linters automated changed (+ fixes to the changes made)

Differential Revision: D78368814

fbshipit-source-id: 253b47cee88a73cfa15c62f2c79444e879176538

Author: georges-berenger

tools/vrsplayer/FileReader.cpp

@@ -191,12 +191,12 @@ class OpenProgressDialog : public ProgressLogger {
  protected:
   void logMessage(const string& message) override {
     ProgressLogger::logMessage(message);
-    progressDialog_.setLabelText(QString().fromStdString(message));
+    progressDialog_.setLabelText(QString::fromStdString(message));
     qApp->processEvents();
   }
   void logErrorMessage(const string& message) override {
     ProgressLogger::logErrorMessage(message);
-    progressDialog_.setLabelText(QString().fromStdString(message));
+    progressDialog_.setLabelText(QString::fromStdString(message));
     qApp->processEvents();
   }
   void updateStep(size_t progress, size_t maxProgress) override {
@@ -429,7 +429,7 @@ vector<FrameWidget*> FileReader::openFile(QVBoxLayout* videoFrames, QWidget* wid
   return frames;
 }
 
-void FileReader::setOverlayColor(QColor color) {
+void FileReader::setOverlayColor(const QColor& color) {
   for (auto& image : imageReaders_) {
     image.second->getWidget()->setOverlayColor(color);
   }
@@ -1243,7 +1243,7 @@ void FileReader::loadConfiguration() {
   fileConfig_ = make_unique<QSettings>("VRSplayer", ss.str().c_str());
   layoutPresets_ = fileConfig_->value(kLayoutPresets).toMap();
   if (DEBUG_CONFIG) {
-    for (auto key : layoutPresets_.keys()) {
+    for (const auto& key : layoutPresets_.keys()) {
       QJsonDocument jdoc = QJsonDocument::fromVariant(layoutPresets_[key]);
       QByteArray config = jdoc.toJson();
       XR_LOGI("\nPreset {}: {}", key.toStdString(), string(config.constData(), config.size()));
@@ -1302,7 +1302,7 @@ void FileReader::setTimeRange(double start, double end, uint32_t firstDataRecord
   firstDataRecordIndex_ = firstDataRecordIndex;
   durationChanged(start, end, rawTimeToPosition(endTime_ - startTime_));
   cout << "Player time range: " << helpers::humanReadableTimestamp(startTime_) << " - "
-       << helpers::humanReadableTimestamp(end) << endl;
+       << helpers::humanReadableTimestamp(end) << '\n';
 }
 
 } // namespace vrsp

tools/vrsplayer/FileReader.h

@@ -121,7 +121,7 @@ class FileReader : public QObject {
 
  public slots:
   std::vector<FrameWidget*> openFile(const QString& url, QVBoxLayout* videoFrame, QWidget* parent);
-  void setOverlayColor(QColor color);
+  void setOverlayColor(const QColor& color);
   void setFontSize(int fontSize);
   void setSolidBackground(bool solid);
   void recordTypeChanged(const QString& type);

tools/vrsplayer/FrameWidget.h

@@ -21,6 +21,7 @@
 #include <map>
 #include <memory>
 #include <mutex>
+#include <utility>
 
 #include <QtCore/qglobal.h>
 #include <QtWidgets/QWidget>
@@ -125,7 +126,7 @@ class FrameWidget : public QWidget {
     setNeedsUpdate();
   }
   void setOverlayColor(QColor color) {
-    overlayColor_ = color;
+    overlayColor_ = std::move(color);
     setNeedsUpdate();
   }
   void setFontSize(int fontSize) {

tools/vrsplayer/PlayerUI.cpp

@@ -18,6 +18,8 @@
 
 #include <cctype>
 
+#include <utility>
+
 #include <fmt/format.h>
 
 #include <qmessagebox.h>
@@ -94,12 +96,7 @@ class JumpSlider : public QSlider {
 
 } // namespace
 
-PlayerUI::PlayerUI(PlayerWindow* playerWindow)
-    : QWidget(nullptr),
-      playerWindow_{playerWindow},
-      time_{nullptr},
-      positionSlider_{nullptr},
-      statusLabel_{nullptr} {
+PlayerUI::PlayerUI(PlayerWindow* playerWindow) : QWidget(nullptr), playerWindow_{playerWindow} {
   fileReader_.setPlayerUi(this);
   connect(
       this,
@@ -419,7 +416,7 @@ void PlayerUI::reportError(const QString& errorTitle, const QString& errorMessag
 }
 
 void PlayerUI::setOverlayColor(QColor color) {
-  overlayColor_ = color;
+  overlayColor_ = std::move(color);
   fileReader_.setOverlayColor(overlayColor_);
   settings_.setValue(kOverlayColorSetting, overlayColor_);
   overlaySettingChanged();

tools/vrsplayer/PlayerUI.h

@@ -110,22 +110,22 @@ class PlayerUI : public QWidget {
   bool eventFilter(QObject* obj, QEvent* event) override;
 
  private:
-  PlayerWindow* playerWindow_;
+  PlayerWindow* playerWindow_{nullptr};
   QSettings settings_;
   QColor overlayColor_{Qt::yellow};
   int fontSize_{14};
   bool solidBackground_{false};
   FileReader fileReader_;
-  QVBoxLayout* videoFrames_;
+  QVBoxLayout* videoFrames_{nullptr};
   std::vector<FrameWidget*> frames_;
-  QAbstractButton* backwardButton_;
-  QAbstractButton* stopButton_;
-  QAbstractButton* playPauseButton_;
-  QAbstractButton* forwardButton_;
-  QComboBox* speedControl_;
-  QLabel* time_;
-  QSlider* positionSlider_;
-  QLabel* statusLabel_;
+  QAbstractButton* backwardButton_{nullptr};
+  QAbstractButton* stopButton_{nullptr};
+  QAbstractButton* playPauseButton_{nullptr};
+  QAbstractButton* forwardButton_{nullptr};
+  QComboBox* speedControl_{nullptr};
+  QLabel* time_{nullptr};
+  QSlider* positionSlider_{nullptr};
+  QLabel* statusLabel_{nullptr};
   QTimer checkForUpdatesTimer_;
   PathPreparer pathPreparer_;
 };