chore(deps): update rust dependencies auto-merge (patch)#745
chore(deps): update rust dependencies auto-merge (patch)#745renovate[bot] merged 1 commit intomainfrom
Conversation
|
PR Review: once_cell patch bump 1.21.3 to 1.21.4. Summary: Routine Renovate patch update to once_cell. Verdict: Safe to merge. |
|
PR Review: once_cell patch bump 1.21.3 to 1.21.4 Summary: Routine Renovate patch update to once_cell. Changes are limited to Cargo.lock (checksum update only - no Cargo.toml version spec change needed since the workspace already pins once_cell = 1.20, which accepts any 1.x patch). Soundness fix: The upstream release notes flag a soundness bug fix: Fix unsoundness in OnceCell::wait under the parking_lot feature flag: if thread A calls wait while thread B calls get_or_try_init(f) and f panics, wait incorrectly returns and thread A observes uninitialized memory. Impact on this repo: This project does not enable the parking_lot feature for once_cell (confirmed in Cargo.toml - no features listed), so the unsoundness bug does not directly affect scotty. Upgrading is still the right call. Assessment: Code quality - No code changes, only a lockfile checksum update. Security - Picks up a soundness fix. Tests - No new tests needed for a lockfile-only dep bump. Performance - No impact. Verdict: Safe to merge. This is a low-risk, beneficial patch update. |
|
PR Review: once_cell patch bump 1.21.3 to 1.21.4 Summary: Routine Renovate patch update to once_cell. Changes are limited to Cargo.lock (checksum update only). The workspace Cargo.toml pins once_cell = 1.20 which accepts any 1.x patch, so only the lockfile changes. Soundness fix: The upstream release notes flag a soundness bug fix: OnceCell::wait under --features=parking_lot could incorrectly return and expose uninitialized memory if another thread's get_or_try_init(f) panicked concurrently. Impact on this repo: This project does NOT enable the parking_lot feature for once_cell (no features listed in Cargo.toml), so the unsoundness bug does not directly affect scotty. Upgrading is still the right call. Assessment:
Verdict: Safe to merge. This is a low-risk, beneficial patch update. |
9ee2aab to
00348a6
Compare
|
PR Review: Dependency Updates (patch) - This is a routine Renovate patch dependency update. Only Cargo.lock is modified. Packages updated: clap 4.5.60 to 4.5.61, clap_derive 4.5.55 to 4.5.61, clap_builder 4.5.60 to 4.5.61, clap_complete 4.5.66 to 4.5.67, anstyle 1.0.10 to 1.0.13, once_cell 1.21.3 to 1.21.4. The once_cell update fixes a soundness bug in OnceCell::wait with parking_lot feature. Risk is very low. This PR looks good to merge. |
00348a6 to
d5c46db
Compare
Dependency Update ReviewThis Renovate PR updates two direct dependencies and pulls in several transitive updates. Direct updates
If scotty uses once_cell with the parking_lot feature enabled, this is an important correctness/safety fix. Worth merging promptly for this alone.
The MSRV bump to 1.85 is worth noting - ensure CI toolchain and deployment environments are on Rust >= 1.85. Transitive updatesThe config bump pulls in notable transitive changes:
TOML 1.1.0 is backwards-compatible with 1.0.0 documents, so existing config files should parse without issues. The existing test suite should cover any edge cases. Summary
|
d5c46db to
5af3872
Compare
CLAUDE.mdThis file provides guidance to Claude Code (claude.ai/code) when working with code in this repository. Project OverviewScotty is a micro Platform-as-a-Service (PaaS) for managing Docker Compose-based applications:
Development Commands# Tests
cargo test # Run all tests
cargo test test_name -- --nocapture # Specific test with output
RUST_LOG=debug cargo test test_name -p scotty -- --nocapture # With debug logging
# Server (use .env file for SCOTTY__API__AUTH_MODE=dev etc.)
SCOTTY__API__AUTH_MODE=dev cargo run --bin scotty # Dev mode (no auth)
RUST_LOG=info cargo run --bin scotty # With logging
cargo run --bin scotty -- config # View configuration
# scottyctl
cargo run --bin scottyctl -- <command>
cargo run --bin scottyctl -- --server http://localhost:21342 --access-token <token> app:list
# Or via env: SCOTTY_SERVER=http://localhost:21342 SCOTTY_ACCESS_TOKEN=<token>
# Frontend (uses bun, not npm)
cd frontend && bun install && bun run dev # Development server
bun run build # Production build
bun run check # Type checking
bun run lint # Prettier + ESLint (must pass before push)
# Prerequisites: start Traefik for local development
cd apps/traefik && docker compose up -dArchitectureScotty Server (
|
1 similar comment
CLAUDE.mdThis file provides guidance to Claude Code (claude.ai/code) when working with code in this repository. Project OverviewScotty is a micro Platform-as-a-Service (PaaS) for managing Docker Compose-based applications:
Development Commands# Tests
cargo test # Run all tests
cargo test test_name -- --nocapture # Specific test with output
RUST_LOG=debug cargo test test_name -p scotty -- --nocapture # With debug logging
# Server (use .env file for SCOTTY__API__AUTH_MODE=dev etc.)
SCOTTY__API__AUTH_MODE=dev cargo run --bin scotty # Dev mode (no auth)
RUST_LOG=info cargo run --bin scotty # With logging
cargo run --bin scotty -- config # View configuration
# scottyctl
cargo run --bin scottyctl -- <command>
cargo run --bin scottyctl -- --server http://localhost:21342 --access-token <token> app:list
# Or via env: SCOTTY_SERVER=http://localhost:21342 SCOTTY_ACCESS_TOKEN=<token>
# Frontend (uses bun, not npm)
cd frontend && bun install && bun run dev # Development server
bun run build # Production build
bun run check # Type checking
bun run lint # Prettier + ESLint (must pass before push)
# Prerequisites: start Traefik for local development
cd apps/traefik && docker compose up -dArchitectureScotty Server (
|
|
PR Review: chore(deps): update rust dependencies auto-merge (patch) Note: This PR has already been merged. This review is provided for informational purposes. Summary This is an automated Renovate dependency update targeting two direct dependencies and their transitive dependency graph. Direct dependencies:
Transitive dependencies (pulled in by the config update):
Assessment Positive:
Worth noting:
No concerns with code quality (lock file only), security (the once_cell fix is a net positive), or test coverage. Overall: Routine and beneficial dependency update. Auto-merge via Renovate is appropriate for these changes. |
This PR contains the following updates:
0.15.19→0.15.211.21.3→1.21.4Release Notes
rust-cli/config-rs (config)
v0.15.21Compare Source
Compatibility
v0.15.20Compare Source
Fixes
u64rangeInternal
matklad/once_cell (once_cell)
v1.21.4Compare Source
Fix unsoundness in
OnceCell::waitunder--features=parking_lot, #295.If thread A calls
wait, while thread B callsget_or_try_init(f), and, furthermore,fpanics,the
waitincorrectly returns and thread A observes uninitialized memory.Kudos to @meng-xu-cs for a nice find!
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.