Skip to content

Commit cfda323

Browse files
authored
fix: improve filter removal logic in Filters component (#1665)
1 parent 4d19829 commit cfda323

File tree

1 file changed

+4
-5
lines changed
  • packages/react/src/experimental/OneDataCollection/Filters

1 file changed

+4
-5
lines changed

packages/react/src/experimental/OneDataCollection/Filters/index.tsx

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -119,11 +119,10 @@ const FiltersRoot = <Definition extends FiltersDefinition>({
119119
const [localFiltersValue, setLocalFiltersValue] = useState(filters)
120120

121121
const removeFilterValue = (key: keyof Definition) => {
122-
setLocalFiltersValue((prev) => {
123-
const { [key]: _, ...rest } = prev
124-
return rest as FiltersState<Definition>
125-
})
126-
props.onChange(localFiltersValue)
122+
const newFilters = { ...localFiltersValue }
123+
delete newFilters[key]
124+
setLocalFiltersValue(newFilters as FiltersState<Definition>)
125+
props.onChange(newFilters as FiltersState<Definition>)
127126
}
128127

129128
const setFiltersValue = (filters: FiltersState<Definition>) => {

0 commit comments

Comments
 (0)