Fix endless update loop in the presence of empty DataSet (#674)

pacher · web-flow · commit 8d15ad2dfafe · 2024-11-20T14:26:17.000+01:00
diff --git a/chartfx-chart/src/main/java/io/fair_acc/chartfx/renderer/spi/AbstractRendererXY.java b/chartfx-chart/src/main/java/io/fair_acc/chartfx/renderer/spi/AbstractRendererXY.java
@@ -122,6 +122,8 @@ protected void updateAxisRange(AxisRange range, int dim) {
     }
 
     protected void updateAxisRange(DataSet dataSet, AxisRange range, int dim) {
+        if (dataSet.getDataCount() == 0)
+            return;
         var dsRange = dataSet.getAxisDescription(dim);
         if (!dsRange.isDefined()) {
             dataSet.recomputeLimits(dim);

Original file line number	Diff line number	Diff line change
`@@ -122,6 +122,8 @@ protected void updateAxisRange(AxisRange range, int dim) {`
`122`	`122`	`}`
`123`	`123`
`124`	`124`	`protected void updateAxisRange(DataSet dataSet, AxisRange range, int dim) {`
	`125`	`+ if (dataSet.getDataCount() == 0)`
	`126`	`+ return;`
`125`	`127`	`var dsRange = dataSet.getAxisDescription(dim);`
`126`	`128`	`if (!dsRange.isDefined()) {`
`127`	`129`	`dataSet.recomputeLimits(dim);`