Skip to content

Commit 8a17ad2

Browse files
committed
Remove unused "topology changed" mechanism
This was never used. It was set but never read and the job list was never updated. With the "zombie list" there's no need for it anymore. Signed-off-by: Sergio Martins <[email protected]>
1 parent 88fd6a0 commit 8a17ad2

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

core/include/gnuradio-4.0/Graph.hpp

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,6 @@ class Graph : public gr::Block<Graph> {
188188
private:
189189
std::shared_ptr<gr::Sequence> _progress = std::make_shared<gr::Sequence>();
190190
std::shared_ptr<gr::thread_pool::BasicThreadPool> _ioThreadPool = std::make_shared<gr::thread_pool::BasicThreadPool>("graph_thread_pool", gr::thread_pool::TaskType::IO_BOUND, 2UZ, std::numeric_limits<uint32_t>::max());
191-
std::atomic_bool _topologyChanged{false};
192191
std::vector<Edge> _edges;
193192
std::vector<std::unique_ptr<BlockModel>> _blocks;
194193

@@ -341,17 +340,12 @@ class Graph : public gr::Block<Graph> {
341340
}
342341
_progress = std::move(other._progress);
343342
_ioThreadPool = std::move(other._ioThreadPool);
344-
_topologyChanged.store(other._topologyChanged.load(std::memory_order_acquire), std::memory_order_release);
345-
_edges = std::move(other._edges);
346-
_blocks = std::move(other._blocks);
343+
_edges = std::move(other._edges);
344+
_blocks = std::move(other._blocks);
347345

348346
return *this;
349347
}
350348

351-
void setTopologyChanged() noexcept { _topologyChanged.store(true, std::memory_order_release); }
352-
[[nodiscard]] bool hasTopologyChanged() const noexcept { return _topologyChanged; }
353-
void ackTopologyChange() noexcept { _topologyChanged.store(false, std::memory_order_release); }
354-
355349
[[nodiscard]] std::span<std::unique_ptr<BlockModel>> blocks() noexcept { return {_blocks}; }
356350
[[nodiscard]] std::span<Edge> edges() noexcept { return {_edges}; }
357351

0 commit comments

Comments
 (0)