Do not allocate in IoBuffer(IoBuffer&&)

resize() allocated memory in the size of the moved-from buffer, which
was then leaked, do not do that.

Signed-off-by: Frank Osterfeld <[email protected]>

Author: frankosterfeld

src/serialiser/include/IoBuffer.hpp

@@ -262,13 +262,11 @@ struct IoBuffer {
     }
 
     [[nodiscard]] IoBuffer(IoBuffer &&other) noexcept
-        : _allocator(other._allocator.select_on_container_copy_construction()) {
-        _buffer       = resize(other._size);
-        _position     = other._position;
-        _capacity     = other.capacity();
-        _buffer       = other._buffer;
-        other._buffer = nullptr;
-    }
+        : _allocator(other._allocator.select_on_container_copy_construction())
+        , _buffer(std::exchange(other._buffer, nullptr))
+        , _position(other._position)
+        , _size(other._size)
+        , _capacity(other._capacity) {}
 
     constexpr ~IoBuffer() {
         freeInternalBuffer();
@@ -288,6 +286,9 @@ struct IoBuffer {
     }
 
     IoBuffer &operator=(IoBuffer &&other) noexcept {
+        if (this == &other) {
+            return *this;
+        }
         auto temp = std::move(other);
         swap(temp);
         return *this;