Skip to content

Commit 6d18498

Browse files
committed
(chore) add support for loadBalancerClass and align Service options
across templates
1 parent 29530b5 commit 6d18498

3 files changed

Lines changed: 19 additions & 3 deletions

File tree

charts/temporal/templates/server-service.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,14 @@ metadata:
1010
{{- end }}
1111
spec:
1212
type: {{ .Values.server.frontend.service.type }}
13+
{{- if eq .Values.server.frontend.service.type "LoadBalancer" }}
14+
{{- with .Values.server.frontend.service.loadBalancerIP }}
15+
loadBalancerIP: {{ . }}
16+
{{- end }}
17+
{{- with .Values.server.frontend.service.loadBalancerClass }}
18+
loadBalancerClass: {{ . }}
19+
{{- end }}
20+
{{- end }}
1321
ports:
1422
- port: {{ .Values.server.frontend.service.port }}
1523
targetPort: rpc

charts/temporal/templates/web-service.yaml

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,15 @@ metadata:
99
annotations: {{- include "common.tplvalues.render" ( dict "value" .Values.web.service.annotations "context" $) | nindent 4 }}
1010
{{- end }}
1111
spec:
12-
{{- with .Values.web.service.loadBalancerIP }}
13-
loadBalancerIP: {{.}}
14-
{{- end }}
1512
type: {{ .Values.web.service.type }}
13+
{{- if eq .Values.web.service.type "LoadBalancer" }}
14+
{{- with .Values.web.service.loadBalancerIP }}
15+
loadBalancerIP: {{ . }}
16+
{{- end }}
17+
{{- with .Values.web.service.loadBalancerClass }}
18+
loadBalancerClass: {{ . }}
19+
{{- end }}
20+
{{- end }}
1621
ports:
1722
- port: {{ .Values.web.service.port }}
1823
targetPort: http

charts/temporal/values.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -211,6 +211,8 @@ server:
211211
# Evaluated as template
212212
annotations: {}
213213
type: ClusterIP
214+
# loadBalancerIP:
215+
# loadBalancerClass:
214216
port: 7233
215217
membershipPort: 6933
216218
httpPort: 7243
@@ -374,6 +376,7 @@ web:
374376
port: 8080
375377
annotations: {}
376378
# loadBalancerIP:
379+
# loadBalancerClass:
377380
ingress:
378381
enabled: false
379382
# className:

0 commit comments

Comments
 (0)