optimize language validate (pestphp#75)

faissaloux · web-flow · commit 756628f3bdc6 · 2025-06-19T10:05:05.000+01:00
We only need to call `validateLanguages` when `--language` is passed.
diff --git a/src/Plugin.php b/src/Plugin.php
@@ -79,6 +79,7 @@ public function handleOriginalArguments(array $arguments): void
             if (str_starts_with($argument, '--language=')) {
                 $languageValue = substr($argument, strlen('--language='));
                 $this->languages = explode(',', $languageValue);
+                $invalidLanguages = Validator::validateLanguages($this->languages);
                 unset($arguments[$key]);
             }
 
@@ -99,7 +100,6 @@ public function handleOriginalArguments(array $arguments): void
             }
         }
 
-        $invalidLanguages = Validator::validateLanguages($this->languages);
         if (! empty($invalidLanguages)) {
             $invalidLangsStr = implode(', ', $invalidLanguages);
             Output::errorMessage("The specified language does not exist: $invalidLangsStr");

Original file line number	Diff line number	Diff line change
`@@ -79,6 +79,7 @@ public function handleOriginalArguments(array $arguments): void`
`79`	`79`	`if (str_starts_with($argument, '--language=')) {`
`80`	`80`	`$languageValue = substr($argument, strlen('--language='));`
`81`	`81`	`$this->languages = explode(',', $languageValue);`
	`82`	`+ $invalidLanguages = Validator::validateLanguages($this->languages);`
`82`	`83`	`unset($arguments[$key]);`
`83`	`84`	`}`
`84`	`85`
`@@ -99,7 +100,6 @@ public function handleOriginalArguments(array $arguments): void`
`99`	`100`	`}`
`100`	`101`	`}`
`101`	`102`
`102`		`- $invalidLanguages = Validator::validateLanguages($this->languages);`
`103`	`103`	`if (! empty($invalidLanguages)) {`
`104`	`104`	`$invalidLangsStr = implode(', ', $invalidLanguages);`
`105`	`105`	`Output::errorMessage("The specified language does not exist: $invalidLangsStr");`