Skip to content

Commit 59fe175

Browse files
authored
[ES|QL][Discover] Applies the breakdown first and then the date_histogram (elastic#239685)
1 parent abd18b0 commit 59fe175

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

src/platform/packages/shared/kbn-unified-histogram/services/lens_vis_service.suggestions.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,7 @@ describe('LensVisService suggestions', () => {
286286

287287
const histogramQuery = {
288288
esql: `from the-data-view | limit 100
289-
| STATS results = COUNT(*) BY timestamp = BUCKET(@timestamp, 30 minute), \`var0\` | sort \`var0\` asc`,
289+
| STATS results = COUNT(*) BY \`var0\`, timestamp = BUCKET(@timestamp, 30 minute) | sort \`var0\` asc`,
290290
};
291291

292292
expect(lensVis.visContext?.attributes.state.query).toStrictEqual(histogramQuery);
@@ -367,7 +367,7 @@ describe('LensVisService suggestions', () => {
367367

368368
const histogramQuery = {
369369
esql: `from the-data-view | limit 100
370-
| STATS results = COUNT(*) BY timestamp = BUCKET(@timestamp, 30 minute), \`coordinates\``,
370+
| STATS results = COUNT(*) BY \`coordinates\`, timestamp = BUCKET(@timestamp, 30 minute)`,
371371
};
372372

373373
expect(lensVis.visContext?.attributes.state.query).toStrictEqual(histogramQuery);

src/platform/packages/shared/kbn-unified-histogram/services/lens_vis_service.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -619,7 +619,7 @@ export class LensVisService {
619619
const language = getAggregateQueryMode(query);
620620
const safeQuery = removeDropCommandsFromESQLQuery(query[language]);
621621
const normalizedQuery = convertTimeseriesCommandToFrom(safeQuery);
622-
const breakdown = breakdownColumn ? `, \`${breakdownColumn.name}\`` : '';
622+
const breakdown = breakdownColumn ? `\`${breakdownColumn.name}\`, ` : '';
623623

624624
// sort by breakdown column if it's sortable
625625
const sortBy =
@@ -630,7 +630,7 @@ export class LensVisService {
630630
const timeBuckets = `${TIMESTAMP_COLUMN} = BUCKET(${dataView.timeFieldName}, ${queryInterval})`;
631631
return appendToESQLQuery(
632632
normalizedQuery,
633-
`| STATS results = COUNT(*) BY ${timeBuckets}${breakdown}${sortBy}`
633+
`| STATS results = COUNT(*) BY ${breakdown}${timeBuckets}${sortBy}`
634634
);
635635
};
636636

0 commit comments

Comments
 (0)