add mobile, location to hash. add client test coverage

Author: fakenine

.rspec

@@ -0,0 +1 @@
+--colour

Rakefile

@@ -1 +1,6 @@
 require "bundler/gem_tasks"
+require "rspec/core/rake_task"
+
+RSpec::Core::RakeTask.new(:spec)
+
+task default: :spec

lib/omniauth/marvin/version.rb

@@ -1,5 +1,5 @@
 module Omniauth
   module Marvin
-    VERSION = "0.1.0"
+    VERSION = "0.1.1"
   end
 end

lib/omniauth/strategies/marvin.rb

@@ -3,7 +3,7 @@
 module OmniAuth
   module Strategies
     class Marvin < OmniAuth::Strategies::OAuth2
-      option :name, :marvin
+      option :name, "marvin"
 
       option :client_options, {
         site: "https://api.intrav2.42.fr",
@@ -18,12 +18,14 @@ class Marvin < OmniAuth::Strategies::OAuth2
           login: raw_info["login"],
           url: raw_info["url"],
           name: raw_info["displayname"],
+          mobile: raw_info["mobile"],
           image: raw_info["image_url"],
           staff?: raw_info["staff?"],
           correction_point: raw_info["correction_point"],
           wallet: raw_info["wallet"],
           level: raw_info["cursus"]["level"],
-          grade: raw_info["cursus"]["grade"]
+          grade: raw_info["cursus"]["grade"],
+          location: raw_info["location"]
         }
       end
 

omniauth-marvin.gemspec

@@ -28,7 +28,9 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_runtime_dependency 'omniauth-oauth2', '~> 1.2'
+  spec.add_runtime_dependency 'multi_json', '~> 1.3'
 
   spec.add_development_dependency "bundler", "~> 1.10"
   spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency 'rspec'
 end

spec/omniauth/strategies/omniauth_marvin_spec.rb

@@ -0,0 +1,29 @@
+require "spec_helper"
+require "omniauth-marvin"
+
+describe OmniAuth::Strategies::Marvin do
+  let(:request) { double('Request', :params => {}, :cookies => {}, :env => {}) }
+
+  subject do
+    args = ['appid', 'secret', @options || {}].compact
+    OmniAuth::Strategies::Marvin.new(*args).tap do |strategy|
+      allow(strategy).to receive(:request) {
+        request
+      }
+    end
+  end
+
+  describe "client options" do
+    it 'has a correct name' do
+      expect(subject.options.name).to eq("marvin")
+    end
+
+    it 'has a correct site' do
+      expect(subject.options.client_options.site).to eq("https://api.intrav2.42.fr")
+    end
+
+    it "has a valid auth url" do
+      expect(subject.options.client_options.authorize_path).to eq("v2/oauth/authorize")
+    end
+  end
+end

spec/spec_helper.rb

@@ -0,0 +1,2 @@
+require "bundler/setup"
+require "rspec"