-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Inconsistent default of faker.number.bigInt max option #3364
Copy link
Copy link
Open
Labels
breaking changeCannot be merged when next version is not a major releaseCannot be merged when next version is not a major releasec: bugSomething isn't workingSomething isn't workingm: numberSomething is referring to the number moduleSomething is referring to the number modulep: 1-normalNothing urgentNothing urgents: needs decisionNeeds team/maintainer decisionNeeds team/maintainer decision
Milestone
Metadata
Metadata
Assignees
Labels
breaking changeCannot be merged when next version is not a major releaseCannot be merged when next version is not a major releasec: bugSomething isn't workingSomething isn't workingm: numberSomething is referring to the number moduleSomething is referring to the number modulep: 1-normalNothing urgentNothing urgents: needs decisionNeeds team/maintainer decisionNeeds team/maintainer decision
Fields
Give feedbackNo fields configured for issues without a type.
Currently, all methods except faker.number.bigInt have a fixed default
maxoption:faker/src/modules/number/index.ts
Line 25 in bdd55ad
faker/src/modules/number/index.ts
Line 111 in bdd55ad
faker/src/modules/number/index.ts
Line 229 in bdd55ad
faker/src/modules/number/index.ts
Line 279 in bdd55ad
faker/src/modules/number/index.ts
Line 329 in bdd55ad
vs
faker/src/modules/number/index.ts
Line 377 in bdd55ad
For consistency with the other methods, the
maxvalue should be hardcoded similar to the other methods.Since this would be a breaking change(?), it should be changed only in the next major version.
Found while reviewing: #3363