Skip to content

Commit d9b14dc

Browse files
committed
refactor(hooks): DRY on_request regex
1 parent de280ef commit d9b14dc

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

falcon/hooks.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@
5555
_DECORABLE_METHOD_NAME = re.compile(
5656
r'^on_({})(_\w+)?$'.format('|'.join(method.lower() for method in COMBINED_METHODS))
5757
)
58+
_DECORABLE_ON_REQUEST_METHOD_NAME = re.compile(r'^on_request(_\w+)?$')
5859

5960
_ON_REQUEST_SKIPPED_WARNING = (
6061
'Skipping decoration of default responder {responder_name!r} on resource '
@@ -141,7 +142,7 @@ def _before(responder_or_resource: _R) -> _R:
141142

142143
setattr(responder_or_resource, responder_name, do_before_all)
143144

144-
if re.compile(r'^on_request(_\w+)?$').match(responder_name):
145+
if _DECORABLE_ON_REQUEST_METHOD_NAME.match(responder_name):
145146
# Only wrap default responders if decorate_on_request is set to True
146147
if decorate_on_request:
147148
responder = cast('Responder', responder)
@@ -206,7 +207,7 @@ def _after(responder_or_resource: _R) -> _R:
206207

207208
setattr(responder_or_resource, responder_name, do_after_all)
208209

209-
if re.compile(r'^on_request(_\w+)?$').match(responder_name):
210+
if _DECORABLE_ON_REQUEST_METHOD_NAME.match(responder_name):
210211
# Only wrap default responders if decorate_on_request is set to True
211212
if decorate_on_request:
212213
responder = cast('Responder', responder)

0 commit comments

Comments
 (0)