Skip to content

Commit 00fb9d1

Browse files
docs(action): say that a clean run posts no first comment (#121)
Signed-off-by: Bart Waardenburg <bart@waardenburg.dev>
1 parent ac711bb commit 00fb9d1

4 files changed

Lines changed: 7 additions & 5 deletions

File tree

‎action.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ inputs:
5656
required: false
5757
default: ''
5858
comment:
59-
description: 'Post or update one sticky pull request comment with the gates and the findings. Needs `permissions: pull-requests: write`. A pull request from a fork posts no comment.'
59+
description: 'Post or update one sticky pull request comment with the gates and the findings. A clean run posts no first comment. Needs `permissions: pull-requests: write`. A pull request from a fork posts no comment.'
6060
required: false
6161
default: 'false'
6262
comment-key:

‎action/README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ does not fail on them:
108108
| `auto-changed-since` | `false` | On a pull request, pass the base commit of the pull request as `--changed-since` when `changed-since` is empty. |
109109
| `baseline` | empty | A baseline file from `--save-baseline`, relative to `working-directory`. The action passes it as `--baseline`. |
110110
| `save-baseline` | empty | Write the findings of the run to this file (`--save-baseline`). The run then exits 0. |
111-
| `comment` | `false` | Post one sticky comment on the pull request, or update it. See [Pull request comment](#pull-request-comment). |
111+
| `comment` | `false` | Post one sticky comment on the pull request, or update it. A clean run posts no first comment. See [Pull request comment](#pull-request-comment). |
112112
| `comment-key` | empty | The key of the sticky comment. Use letters, digits, `.`, `-` and `_`. When empty, the action uses the command name. Give each call its own key when two calls run the same command. |
113113
| `artifacts-dir` | empty | The folder for the report files. When empty, the action makes a new folder in `RUNNER_TEMP` for each call. |
114114
| `github-token` | `github.token` | The token for the code scanning check, the SARIF upload and the pull request comment. |

‎ci/gitlab-ci.yml‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
# Run the static checks of cargo-fallow on a Rust workspace. The job writes a
44
# GitLab code quality report, so the merge request widget shows the findings.
55
# With CARGO_FALLOW_COMMENT it also posts one merge request note with the
6-
# markdown report, and updates that note on the next run.
6+
# markdown report, and updates that note on the next run. A clean run posts
7+
# no first note.
78
#
89
# Usage: add to your .gitlab-ci.yml:
910
#
@@ -52,7 +53,8 @@
5253
# CARGO_FALLOW_AUTO_CHANGED_SINCE is "true".
5354
CARGO_FALLOW_CHANGED_SINCE: ""
5455
CARGO_FALLOW_AUTO_CHANGED_SINCE: "true"
55-
# "true" posts one merge request note. It needs GITLAB_TOKEN with the api
56+
# "true" posts one merge request note, but a clean run posts no first
57+
# note. It needs GITLAB_TOKEN with the api
5658
# scope, as a masked CI/CD variable: CI_JOB_TOKEN cannot write notes.
5759
CARGO_FALLOW_COMMENT: "false"
5860
# The marker of the note. Give each job with a note its own key.

‎docs/gitlab.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ the vendored scripts.
3030
| `CARGO_FALLOW_FAIL_ON_ISSUES` | `true` | Fail the job when an enforced gate fails. |
3131
| `CARGO_FALLOW_CHANGED_SINCE` | empty | A ref for `--changed-since`. |
3232
| `CARGO_FALLOW_AUTO_CHANGED_SINCE` | `true` | In a merge request pipeline without `CARGO_FALLOW_CHANGED_SINCE`, give `--changed-since` the merge request base. The code quality report always has the full scope: GitLab compares it with the report of the target branch. |
33-
| `CARGO_FALLOW_COMMENT` | `false` | Post or update one merge request note. |
33+
| `CARGO_FALLOW_COMMENT` | `false` | Post or update one merge request note. A clean run posts no first note. |
3434
| `CARGO_FALLOW_COMMENT_KEY` | the command | The marker of the note. Give each job with a note its own key. |
3535
| `CARGO_FALLOW_INSTALL` | `cargo` | `cargo` runs `cargo install cargo-fallow`. `path` uses the `cargo-fallow` on the `PATH`. |
3636
| `CARGO_FALLOW_VERSION` | empty | The crates.io version for `cargo`. Empty means the newest version. Pin it: the cache then keeps the binary, and the next job does not build it. |

0 commit comments

Comments
 (0)