Add support for displaying custom token address #154
Conversation
jcheese1
commented
Mar 8, 2023
jcheese1
commented
|
@jcheese1 is attempting to deploy a commit to the LFE Team on Vercel. A member of the Team first needs to authorize it. |
|
@lochie would be great if you can take a look at this PR. so close to having it on our app :D |
lochie
left a comment
lochie
left a comment
There was a problem hiding this comment.
This is a great feature! But I've left a few comments regarding some small changes.
Would also be great to see an example of implementation within the testbench so we can test the functionality before merging
| type Chain = { id: number; name: string; logo: ReactNode }; | ||
| const supportedChains: Chain[] = [ |
There was a problem hiding this comment.
Any reason why this type has been removed?
There was a problem hiding this comment.
as const already infers it, so I thought its unnecessary
| {nFormatter(Number(balance?.formatted))} | ||
| </span> | ||
| {!hideSymbol && ` ${balance?.symbol}`} | ||
| {!hideSymbol || customTokenAddress ? ` ${balance?.symbol}` : null} |
There was a problem hiding this comment.
Don't think these || customTokenAddress checks should be here, nothing should override the hide options.
There was a problem hiding this comment.
AFAIK !hideSymbol is not configurable on the consumer side yet? Please correct me if I'm wrong :D
packages/connectkit/src/components/Common/ChainSelectList/index.tsx
Outdated
Show resolved
Hide resolved
…jcheese1/connectkit into add_support_for_displaying_custom_token
|
@lochie added an example on testbench |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
any update? |
|
@lochie would be great if we can get this in too :D |
3 participants
