test(KeyRegistry): add test coverage for Ownable2Step #410
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As mentioned on issue #262, I added few test cases to have test coverage for Ownable2Step for KeyRegistry contract.
Also formatted some contracts with
forge fmt
along the updates.Change Summary
Added test cases for coverage on Ownable2Step for KeyRegistry contract, mainly are fuzz testings on transferring ownership to new owner and revert cases on unauthorized acceptance.
Merge Checklist
Choose all relevant options below by adding an
x
now or at any time before submitting for reviewPR-Codex overview
This PR focuses on code formatting improvements and the addition of new tests for ownership transfer functionality in the
KeyRegistry
. It enhances readability by reducing unnecessary line breaks and ensures consistency in array initializations.Detailed summary
Bundler.gas.t.sol
,BundlerTestSuite.sol
,Bundler.t.sol
, andKeyRegistryTestHelpers.sol
.Bundler
,IdGateway
, andKeyRegistry
inBundlerTestSuite.sol
andLocalDeploy.s.sol
.KeyRegistry.t.sol
.KeyRegistryTest
, including revert scenarios for non-owners and acceptance by new owners.