Replace Buffer with Uint8Array

[dawsbot]

What is the bug?
This is a question about a potential bug!

All instances of JS Buffer could be replaced with Uint8Array. Why would we want to?

TLDR:

1. Buffer does not work cross-platform
2. Buffer modifies a global object which can be accessed by third-party dependencies
3. slice mutates the original object

Additional context (optional)
This is a question and discussion beginning. Please leave feedback! If you want to learn more about why this matters, read here: https://sindresorhus.com/blog/goodbye-nodejs-buffer

[dawsbot]

@paulmillr you may have some expertise or recommendations on this topic 🙏

[paulmillr]

It’s pretty easy. Just replace everything with Uint8Array.from(buffer) at first. then, replace Buffer creation with Uint8Array creation.

If you use Buffer.prototype.toString (“hex”), replace it with bytesToHex from noble hashes.