clean up rnd seed

Author: nyurik

src/test_utils.rs

@@ -25,7 +25,7 @@ use fastpfor::{
     FastPFor128, FastPFor256, FastPForBlock128, FastPForBlock256, JustCopy, VariableByte,
 };
 
-const SEED: u64 = 456;
+pub const RNG_SEED: u64 = 456;
 
 // ---------------------------------------------------------------------------
 // Generic codec helpers
@@ -165,12 +165,12 @@ mod rust_bench {
     use rand::rngs::StdRng;
     use rand::{RngExt as _, SeedableRng};
 
-    use super::{BlockCodec, block_compress};
+    use super::{BlockCodec, RNG_SEED, block_compress};
 
     type DataGeneratorFn = fn(usize) -> Vec<u32>;
 
     fn generate_uniform_data_from_range(size: usize, value_range: Range<u32>) -> Vec<u32> {
-        let mut rng = StdRng::seed_from_u64(super::SEED);
+        let mut rng = StdRng::seed_from_u64(RNG_SEED);
         (0..size)
             .map(|_| rng.random_range(value_range.clone()))
             .collect()
@@ -185,7 +185,7 @@ mod rust_bench {
     }
 
     fn generate_clustered_data(size: usize) -> Vec<u32> {
-        let mut rng = StdRng::seed_from_u64(super::SEED);
+        let mut rng = StdRng::seed_from_u64(RNG_SEED);
         let mut base = 0u32;
         (0..size)
             .map(|_| {
@@ -202,7 +202,7 @@ mod rust_bench {
     }
 
     fn generate_sparse_data(size: usize) -> Vec<u32> {
-        let mut rng = StdRng::seed_from_u64(super::SEED);
+        let mut rng = StdRng::seed_from_u64(RNG_SEED);
         (0..size)
             .map(|_| {
                 if rng.random_bool(0.9) {
@@ -215,7 +215,7 @@ mod rust_bench {
     }
 
     fn generate_constant_data(size: usize) -> Vec<u32> {
-        vec![super::SEED as u32; size]
+        vec![RNG_SEED as u32; size]
     }
 
     fn generate_geometric_data(size: usize) -> Vec<u32> {

tests/basic_tests.rs

@@ -10,7 +10,7 @@ use fastpfor::{BlockCodec, FastPForBlock128, FastPForBlock256, slice_to_blocks};
 use rand::rngs::StdRng;
 use rand::{RngExt as _, SeedableRng};
 
-use crate::test_utils::{block_compress, block_roundtrip_all, roundtrip_all};
+use crate::test_utils::{RNG_SEED, block_compress, block_roundtrip_all, roundtrip_all};
 
 mod common;
 
@@ -51,9 +51,8 @@ fn test_increasing_sequence() {
 
 #[test]
 fn test_random_numbers() {
-    let data: Vec<u32> = (0..65536)
-        .map(|_| StdRng::seed_from_u64(123456).random())
-        .collect();
+    let mut rng = StdRng::seed_from_u64(RNG_SEED);
+    let data: Vec<u32> = (0..65536).map(|_| rng.random()).collect();
     roundtrip_all(&data);
 }
 

tests/common.rs

@@ -3,8 +3,12 @@
 #![cfg(any(feature = "rust", feature = "cpp"))]
 #![allow(dead_code, reason = "This file is shared by several test modules")]
 
+#[path = "../src/test_utils.rs"]
+mod test_utils;
+
 use rand::rngs::StdRng;
 use rand::{RngExt as _, SeedableRng as _};
+use test_utils::RNG_SEED;
 
 /// Returns various input sizes to test codec behavior (multiples of 128).
 #[must_use]
@@ -15,7 +19,7 @@ pub fn test_input_sizes() -> Vec<usize> {
 /// Generates test data vectors of size `n` with various patterns.
 #[must_use]
 pub fn get_test_cases(n: usize) -> Vec<Vec<u32>> {
-    let mut rng = StdRng::seed_from_u64(14);
+    let mut rng = StdRng::seed_from_u64(RNG_SEED);
 
     vec![
         // Zeroes