feedback

Author: nyurik

fuzz/fuzz_targets/decode_arbitrary.rs

@@ -4,7 +4,7 @@
 //!
 //! Why this target is needed
 //! -------------------------
-//! The existing `compress_oracle` target only feeds *well-formed* data to the Rust
+//! The existing `encode_oracle` target only feeds *well-formed* data to the Rust
 //! decoder (it first compresses valid input, then decompresses).
 //! That means corrupted or truncated compressed streams never reach the decoder, so
 //! out-of-bounds panics in `decode_page` are invisible to the fuzzer.

fuzz/justfile

@@ -34,7 +34,7 @@ run-iters target iters='10000' *args:
 # Run encode_oracle (pure Rust roundtrip, no C++ required)
 rust-encode *args: (run 'encode_oracle' args)
 
-# Run decode_oracle (parallel Rust + C++ roundtrips, cross-checks decodeed values)
+# Run decode_oracle (parallel Rust + C++ roundtrips, cross-checks decoded values)
 rust-decode *args: (run 'decode_oracle' args)
 
 # Feed arbitrary bytes directly to the Rust decodeor (no panic check)

justfile

@@ -85,17 +85,15 @@ fmt:
     #!/usr/bin/env bash
     set -euo pipefail
     for dir in "./" "fuzz"; do
-        cd "$dir"
+        pushd "$dir"
         if (rustup toolchain list | grep nightly && rustup component list --toolchain nightly | grep rustfmt) &> /dev/null; then
             echo "Reformatting Rust code using nightly Rust fmt to sort imports in $dir"
             cargo +nightly fmt --all -- --config imports_granularity=Module,group_imports=StdExternalCrate
         else
             echo "Reformatting Rust with the stable cargo fmt in $dir.  Install nightly with \`rustup install nightly\` for better results"
             cargo fmt --all
         fi
-        if [ -f .git ]; then
-            cd ..
-        fi
+        popd
     done
 
 # Reformat all Cargo.toml files using cargo-sort

src/rust/integer_compression/fastpfor.rs

@@ -13,7 +13,7 @@ use crate::{BlockCodec, FastPForError, FastPForResult};
 /// Overhead cost (in bits) for storing each exception's position in the block
 const OVERHEAD_OF_EACH_EXCEPT: u32 = 8;
 
-/// Default page size in number of integers (64 KiB / 4 bytes = 16 Ki integers).
+/// Default page size in number of integers.
 const DEFAULT_PAGE_SIZE: u32 = 65536;
 
 /// Type alias for [`FastPFor`] with 128-element blocks.

src/test_utils.rs

@@ -2,12 +2,6 @@
 //! Criterion benchmarks, integration tests, and `#[cfg(test)]` unit tests in the
 //! `fastpfor` crate.
 //!
-//! - **Library unit tests:** `crate::test_utils` via `#[cfg(test)] mod bench_utils` in `lib.rs`
-//!   and `extern crate self as fastpfor` so this file can `use fastpfor::...`.
-//! - **Integration tests:** `#[cfg(test)] #[path = "../src/test_utils.rs"] mod bench_utils`.
-//! - **Criterion benchmarks:** `#[path = "../src/test_utils.rs"] mod bench_utils` (`cfg(test)` is not
-//!   enabled for bench targets, so the module is included unconditionally there).
-//!
 //! Loaded as a module via `#[path]` or as a normal child module, so every item
 //! consumed from outside must be `pub`. Each consumer uses a different subset,
 //! so dead-code is allowed at module scope.

tests/basic_tests.rs

@@ -20,21 +20,6 @@ fn saul_test() {
     roundtrip_all(&[2u32, 3, 4, 5]);
 }
 
-/// Sub-block-sized inputs produce no output via `BlockCodec`.
-#[test]
-fn spurious_out_test() {
-    fn check<C: BlockCodec + Default>(len: usize) {
-        let x = vec![0u32; 1024];
-        let (blocks, _) = slice_to_blocks::<C>(&x[..len]);
-        let out = block_compress::<C>(cast_slice(blocks)).unwrap();
-        assert!(out.is_empty() || blocks.is_empty());
-    }
-    for len in 0..32usize {
-        check::<FastPForBlock256>(len);
-        check::<FastPForBlock128>(len);
-    }
-}
-
 /// `AnyLenCodec` round-trips empty input correctly.
 #[test]
 fn zero_in_zero_out_test() {