chore: many org cleanups, new err on bad input (#86)

nyurik · web-flow · commit aa7843c7f26b · 2026-07-17T11:50:49.000-05:00
diff --git a/.editorconfig b/.editorconfig
@@ -0,0 +1,14 @@
+root = true
+
+[*]
+charset = utf-8
+end_of_line = lf
+indent_style = space
+insert_final_newline = true
+trim_trailing_whitespace = true
+
+[*.{yml,yaml}]
+indent_size = 2
+
+[.gitmodules]
+indent_style = tab
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -4,7 +4,6 @@ on:
   push:
     branches: [ main ]
   pull_request:
-    branches: [ main ]
   workflow_dispatch:
 
 defaults:
@@ -14,8 +13,7 @@ defaults:
 jobs:
   test:
     name: Test ${{ matrix.os }} (${{ matrix.simd_mode }})
-    permissions:
-      contents: read
+    permissions: { contents: read }
     runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false
@@ -52,8 +50,7 @@ jobs:
 
   test-msrv:
     name: Test MSRV
-    permissions:
-      contents: read
+    permissions: { contents: read }
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
@@ -69,16 +66,14 @@ jobs:
         uses: dtolnay/rust-toolchain@e97e2d8cc328f1b50210efc529dca0028893a2d9 # v1
         with:
           toolchain: ${{ steps.msrv.outputs.value }}
-      - run: just ci_mode=0 ci-test-msrv  # Ignore warnings in MSRV
+      - run: just ci-test-msrv
 
   fuzz:
     name: Fuzz
-    permissions:
-      contents: read
+    permissions: { contents: read }
     runs-on: ubuntu-latest
-    env:
-      # The number of seconds to run the fuzz target.
-      FUZZ_TIME: 60
+    # The number of seconds to run the fuzz target.
+    env: { FUZZ_TIME: 60 }
     strategy:
       matrix:
         include:
@@ -109,8 +104,7 @@ jobs:
 
   coverage:
     name: Code Coverage
-    permissions:
-      contents: read
+    permissions: { contents: read }
     if: github.event_name != 'release'
     runs-on: ubuntu-latest
     steps:
@@ -119,13 +113,12 @@ jobs:
       - uses: Swatinem/rust-cache@c19371144df3bb44fab255c43d04cbc2ab54d1c4 # v2.9.1
       - uses: taiki-e/install-action@b8cecb83565409bcc297b2df6e77f030b2a468d5 # v2.82.0
         with: { tool: 'just,cargo-llvm-cov' }
-      - name: Generate code coverage
-        run: just ci-coverage
+      - run: just ci-coverage
       - name: Upload coverage to Codecov
         uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f # v7.0.0
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
-          files: target/llvm-cov/codecov.info
+          files: target/llvm-cov/lcov.info
 
   # This job checks if any of the previous jobs failed or were canceled.
   # This approach also allows some jobs to be skipped if they are not needed.
@@ -142,16 +135,17 @@ jobs:
 
   release:
     # Some dependencies of the `ci-passed` job might be skipped, but we still want to run if the `ci-passed` job succeeded.
-    if: always() && startsWith(github.ref, 'refs/tags/') && needs.ci-passed.result == 'success'
+    if: |
+      always()
+      && startsWith(github.ref, 'refs/tags/')
+      && needs.ci-passed.result == 'success'
     name: Publish to crates.io
-    permissions:
-      contents: read
+    permissions: { contents: read }
     needs: [ ci-passed ]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
         with: { persist-credentials: false, submodules: recursive }
-      - name: Publish to crates.io
-        run: cargo publish
+      - run: cargo publish
         env:
           CARGO_REGISTRY_TOKEN: ${{ secrets.CARGO_REGISTRY_TOKEN }}
diff --git a/.github/workflows/dependabot.yml b/.github/workflows/dependabot.yml
@@ -11,17 +11,13 @@ jobs:
       - name: Dependabot metadata
         id: metadata
         uses: dependabot/fetch-metadata@25dd0e34f4fe68f24cc83900b1fe3fe149efef98 # v3.1.0
-        with:
-          github-token: "${{ secrets.GITHUB_TOKEN }}"
       - name: Approve Dependabot PRs
         if: steps.metadata.outputs.update-type == 'version-update:semver-patch'
         run: gh pr review --approve "$PR_URL"
         env:
-          PR_URL: ${{github.event.pull_request.html_url}}
-          GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
+          PR_URL: ${{ github.event.pull_request.html_url }}
       - name: Enable auto-merge for Dependabot PRs
         if: steps.metadata.outputs.update-type == 'version-update:semver-patch'
         run: gh pr merge --auto --squash "$PR_URL"
         env:
-          PR_URL: ${{github.event.pull_request.html_url}}
-          GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
+          PR_URL: ${{ github.event.pull_request.html_url }}
diff --git a/.gitignore b/.gitignore
@@ -1,13 +1,27 @@
+**/*.bak
 **/*.rs.bk
+*.iml
 *.pdb
+*.proptest-regressions
+*.pyc
+.DS_Store
+.envrc
 .idea/
+.pytest_cache/
+.venv/
 .vscode/
-Cargo.lock
-codecov*
+__pycache__/
+codecov
+codecov.SHA256SUM*
 debug/
+flamegraph*.svg
+perf.data*
+proptest-regressions/
+rustc-ice-*.txt
 target/
 temp/
 tmp/
 venv/
 
-!codecov.yml
+# This is a library, so the lock file is not committed.
+Cargo.lock
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -33,3 +33,8 @@ repos:
         entry: sh -c "cargo fmt --all"
         language: rust
         pass_filenames: false
+
+  - repo: https://github.com/editorconfig-checker/editorconfig-checker.python
+    rev: 3.6.1
+    hooks:
+      - id: editorconfig-checker
diff --git a/Cargo.toml b/Cargo.toml
@@ -11,7 +11,7 @@ edition = "2024"
 license = "MIT OR Apache-2.0"
 keywords = ["fastpfor", "compression"]
 categories = ["compression"]
-rust-version = "1.86.0"
+rust-version = "1.86"
 
 [package.metadata.docs.rs]
 all-features = true
@@ -51,9 +51,19 @@ unused_qualifications = "warn"
 missing_docs = "warn"
 
 [lints.clippy]
+# Restrictions
+disallowed_methods = "forbid"
+panic_in_result_fn = "warn"
+todo = "warn"
+unimplemented = "warn"
+unwrap_used = "warn"
+use_self = "warn"
+
+# Pedantics without being too noisy
 cargo = { level = "warn", priority = -1 }
 pedantic = { level = "warn", priority = -1 }
-use_self = "warn"
+
+# Relax these for now
 cast_possible_truncation = "allow"
 cast_possible_wrap = "allow"
 cast_sign_loss = "allow"
diff --git a/LICENSE-APACHE b/LICENSE-APACHE
@@ -174,28 +174,3 @@ TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
    of your accepting any such warranty or additional liability.
 
 END OF TERMS AND CONDITIONS
-
-APPENDIX: How to apply the Apache License to your work.
-
-   To apply the Apache License to your work, attach the following
-   boilerplate notice, with the fields enclosed by brackets "[]"
-   replaced with your own identifying information. (Don't include
-   the brackets!)  The text should be enclosed in the appropriate
-   comment syntax for the file format. We also recommend that a
-   file or class name and description of purpose be included on the
-   same "printed page" as the copyright notice for easier
-   identification within third-party archives.
-
-Copyright [yyyy] [name of copyright owner]
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-    http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
diff --git a/LICENSE-MIT b/LICENSE-MIT
@@ -1,7 +1,7 @@
 MIT License
 
 Copyright (c) 2024-2025 Francisco Jimenez <jjcfrank@gmail.com>
-Copyright (c) 2025 Yuri Astrakhan
+Copyright (c) 2025-2026 Yuri Astrakhan
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
diff --git a/README.md b/README.md
@@ -209,8 +209,7 @@ Licensed under either of
 
 * Apache License, Version 2.0 ([LICENSE-APACHE](LICENSE-APACHE) or <https://www.apache.org/licenses/LICENSE-2.0>)
 * MIT license ([LICENSE-MIT](LICENSE-MIT) or <https://opensource.org/licenses/MIT>)
-
-at your option.
+  at your option.
 
 ### Contribution
 
diff --git a/benches/fastpfor_benchmark.rs b/benches/fastpfor_benchmark.rs
@@ -1,5 +1,7 @@
 //! Benchmark suite for `FastPFOR` compression codecs.
 
+#![allow(clippy::unwrap_used)]
+
 use std::hint::black_box;
 
 use criterion::{BenchmarkId, Criterion, Throughput, criterion_group, criterion_main};
diff --git a/build.rs b/build.rs
@@ -61,7 +61,7 @@ fn build_fastpfor() {
         .define("FASTPFOR_SIMD_MODE", simd_mode)
         .build();
     let lib_path = cmake_out.join("lib");
-    let lib_path = lib_path.to_str().unwrap();
+    let lib_path = lib_path.to_str().expect("path is not valid utf-8");
 
     // Compile the bridge
     println!("cargo:rerun-if-changed=src/cpp/fastpfor_bridge.h");
diff --git a/clippy.toml b/clippy.toml
@@ -1,2 +1,10 @@
+allow-mixed-uninlined-format-args = false
 allow-unwrap-in-tests = true
 avoid-breaking-exported-api = false
+
+disallowed-methods = [
+    "alloc::boxed::Box::leak",
+    "alloc::vec::Vec::leak",
+    "std::boxed::Box::leak",
+    "std::vec::Vec::leak",
+]
diff --git a/fuzz/fuzz_targets/encode_compare.rs b/fuzz/fuzz_targets/encode_compare.rs
@@ -50,7 +50,7 @@ fuzz_target!(|data: FuzzInput<PairSelector>| {
         pair.name,
     );
 
-    decoded.truncate(0);
+    decoded.clear();
     cpp_codec
         .decode(&cpp_out, &mut decoded, None)
         .expect("C++ decode of self-compressed data must not fail");
diff --git a/justfile b/justfile
diff --git a/src/cpp/wrappers.rs b/src/cpp/wrappers.rs
diff --git a/src/error.rs b/src/error.rs
diff --git a/src/test_utils.rs b/src/test_utils.rs
diff --git a/tests/decode_validation.rs b/tests/decode_validation.rs
diff --git a/tomlfmt.toml b/tomlfmt.toml
