Refactor redundant random item creation

Author: raphaeltannous

backend/tests/api/routes/test_users.py

@@ -8,7 +8,7 @@
 from app.core.config import settings
 from app.core.security import verify_password
 from app.models import Item, User, UserCreate
-from tests.utils.item import create_random_item_for_user
+from tests.utils.item import create_random_item
 from tests.utils.user import create_random_user
 from tests.utils.utils import random_email, random_lower_string
 
@@ -529,8 +529,8 @@ def test_delete_user_me_deletes_items(client: TestClient, db: Session) -> None:
     user = crud.create_user(session=db, user_create=user_in)
     user_id = user.id
 
-    create_random_item_for_user(db, user_id)
-    create_random_item_for_user(db, user_id)
+    create_random_item(db, user_id)
+    create_random_item(db, user_id)
 
     items_query = select(Item).where(Item.owner_id == user_id)
     items_result = db.exec(items_query).all()
@@ -565,8 +565,8 @@ def test_delete_user_super_user_deletes_items(
     user = crud.create_user(session=db, user_create=user_in)
     user_id = user.id
 
-    create_random_item_for_user(db, user_id)
-    create_random_item_for_user(db, user_id)
+    create_random_item(db, user_id)
+    create_random_item(db, user_id)
 
     items_query = select(Item).where(Item.owner_id == user_id)
     items_result = db.exec(items_query).all()

backend/tests/utils/item.py

@@ -8,17 +8,10 @@
 from tests.utils.utils import random_lower_string
 
 
-def create_random_item(db: Session) -> Item:
-    user = create_random_user(db)
-    owner_id = user.id
-    assert owner_id is not None
-    title = random_lower_string()
-    description = random_lower_string()
-    item_in = ItemCreate(title=title, description=description)
-    return crud.create_item(session=db, item_in=item_in, owner_id=owner_id)
-
-
-def create_random_item_for_user(db: Session, owner_id: uuid.UUID) -> Item:
+def create_random_item(db: Session, owner_id: uuid.UUID | None = None) -> Item:
+    if owner_id is None:
+        user = create_random_user(db)
+        owner_id = user.id
     assert owner_id is not None
     title = random_lower_string()
     description = random_lower_string()