Merge pull request #374 from faster-cpython/minor-changes

Some minor changes suggested by Copilot

Author: mdboom

bench_runner/scripts/backfill.py

@@ -45,7 +45,7 @@ def __init__(self, cpython: PathLike, ref: str, source: str):
         self.source = source
         self.runners: list[RunnerType] = []
 
-    def _set_hash_and_date(self):
+    def _set_hash_and_date(self) -> None:
         self._hash, self._date = _get_hash_and_date(self.cpython, self.ref)
 
     @property

bench_runner/scripts/compare.py

@@ -9,7 +9,7 @@
 import argparse
 from pathlib import Path
 import sys
-from typing import TextIO, Iterable, Sequence, TypeAlias
+from typing import Literal, TextIO, Iterable, Sequence, TypeAlias
 
 
 import rich
@@ -25,7 +25,7 @@
 
 ParsedCommits: TypeAlias = Sequence[
     tuple[str, list[str], str, Iterable[mod_result.Result]]
-]
+]  # (commit_hash, flags, name, results)
 
 
 def parse_commit(commit: str) -> tuple[str, str, list[str]]:
@@ -143,7 +143,9 @@ def do_many_to_many(
     fd.write("\n\nRows are 'bases', columns are 'heads'\n")
 
 
-def _main_with_hashes(commits: Sequence[str], output_dir: Path, comparison_type: str):
+def _main_with_hashes(
+    commits: Sequence[str], output_dir: Path, comparison_type: Literal["1:n", "n:n"]
+):
     results = mod_result.load_all_results(
         None, Path("results"), sorted=False, match=False
     )
@@ -228,7 +230,9 @@ def _main_with_files(commits: Sequence[str], output_dir: Path, comparison_type:
     rich.print()
 
 
-def _main(commits: Sequence[str], output_dir: PathLike, comparison_type: str):
+def _main(
+    commits: Sequence[str], output_dir: PathLike, comparison_type: Literal["1:n", "n:n"]
+):
     if len(commits) < 2:
         raise ValueError("Must provide at least 2 commits")
 

bench_runner/scripts/generate_results.py

@@ -47,11 +47,6 @@ def recurse(entry: tuple, d: dict):
     return d
 
 
-def _worker(args) -> None:
-    func, output_filename = args
-    func(output_filename)
-
-
 def save_generated_results(results: Iterable[Result], force: bool = False) -> None:
     """
     Write out the comparison tables and plots for every result.

bench_runner/scripts/get_merge_base.py

@@ -13,7 +13,7 @@
 from bench_runner.util import PathLike
 
 
-def get_python_version(cpython: PathLike):
+def get_python_version(cpython: PathLike) -> str:
     with (Path(cpython) / "Include" / "patchlevel.h").open() as fd:
         for line in fd.readlines():
             if m := re.match(r'#define\s+PY_VERSION\s+"(.+)"', line.strip()):

bench_runner/scripts/notify.py

@@ -30,7 +30,7 @@ def _main(
     github_repo = os.environ.get("GITHUB_REPOSITORY", "UNKNOWN")
 
     lines = ["🤖 This is the friendly benchmarking bot with some new results!", ""]
-    line = f"@{actor}: " f"[{fork}/{ref}]"
+    line = f"@{actor}: [{fork}/{ref}]"
     skip_publish = (
         config.get_bench_runner_config().get("publish_mirror", {}).get("skip", False)
     )