Bugfixes

Author: mdboom

Diff for: bench_runner/scripts/workflow.py

@@ -257,6 +257,13 @@ def _main(
     venv = Path("venv")
     cpython = Path("cpython")
 
+    if force_32bit and sys.platform != "win32":
+        raise RuntimeError("32-bit builds are only supported on Windows")
+    if perf and not sys.platform.startswith("linux"):
+        raise RuntimeError("perf profiling is only supported on Linux")
+    if pystats and not sys.platform.startswith("linux"):
+        raise RuntimeError("Pystats is only supported on Linux")
+
     checkout_cpython(fork, ref, cpython)
 
     if not should_run(force, fork, ref, machine, False, flags, cpython=cpython):

Diff for: bench_runner/templates/workflow_bootstrap.py

@@ -61,11 +61,9 @@ def main():
     # Now that we've installed the full bench_runner library,
     # continue on in a new process...
 
-    last_arg = sys.argv.find("workflow_bootstrap.py")
+    last_arg = sys.argv.index("workflow_bootstrap.py")
     if last_arg == -1:
-        raise ValueError(
-            "The script should be run from the command line with the workflow_bootstrap.py argument"
-        )
+        raise ValueError("Couldn't parse command line")
 
     run_in_venv(venv, "bench_runner", ["workflow", *sys.argv[last_arg + 1 :]])
 

Diff for: tests/test_run_benchmarks.py

@@ -246,7 +246,6 @@ def test_should_run_exists_force(benchmarks_checkout, monkeypatch):
     removed_paths = []
 
     def remove(repo, path):
-        nonlocal removed_paths
         removed_paths.append(path)
         (repo / path).unlink()