Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Commit 24ddfaa

Browse files
committed
fix(release): use sdk/rust package path for clarity
- Change package key from 'sdk' to 'sdk/rust' for consistency - Aligns with other language SDKs (sdk/go, sdk/python, sdk/typescript) - Updates all workflows to use sdk/rust references - Fixes 'is not a package manifest' error by pointing to correct path In a polyglot repo, sdk/rust is much clearer than just 'sdk'.
1 parent a53511f commit 24ddfaa

File tree

6 files changed

+17
-18
lines changed

6 files changed

+17
-18
lines changed

.github/workflows/pr-conventional-commits.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ jobs:
3535
revert
3636
scopes: |
3737
cli
38-
sdk
3938
sdk/go
39+
sdk/rust
4040
sdk/python
4141
sdk/typescript
4242
wasm
@@ -92,7 +92,7 @@ jobs:
9292
9393
### Examples
9494
- \`feat(cli): add support for dry-run deployments\`
95-
- \`fix(sdk): resolve WASM runtime panic\`
95+
- \`fix(sdk/rust): resolve WASM runtime panic\`
9696
- \`docs: update installation instructions\`
9797
- \`chore(deps): update dependencies\`
9898
@@ -111,8 +111,8 @@ jobs:
111111
112112
### Valid Scopes (optional)
113113
- **cli**: Changes to the FTL CLI
114-
- **sdk**: Rust SDK specific changes
115114
- **sdk/go**: Go SDK specific changes
115+
- **sdk/rust**: Rust SDK specific changes
116116
- **sdk/python**: Python SDK specific changes
117117
- **sdk/typescript**: TypeScript SDK specific changes
118118
- **wasm**: WASM component changes
@@ -197,7 +197,7 @@ jobs:
197197
1,
198198
'always',
199199
[
200-
'cli', 'sdk', 'sdk/go', 'sdk/python',
200+
'cli', 'sdk/go', 'sdk/rust', 'sdk/python',
201201
'sdk/typescript', 'wasm', 'components', 'core',
202202
'deps', 'release', 'docs', 'ci'
203203
]
@@ -349,8 +349,8 @@ jobs:
349349
if (scope) {
350350
const scopeLabels = {
351351
'cli': 'cli',
352-
'sdk': 'rust-sdk',
353352
'sdk/go': 'go-sdk',
353+
'sdk/rust': 'rust-sdk',
354354
'sdk/python': 'python-sdk',
355355
'sdk/typescript': 'typescript-sdk',
356356
'wasm': 'wasm',

.github/workflows/release-please.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@ jobs:
3535
go_sdk_released: ${{ steps.release.outputs['sdk/go--release_created'] }}
3636
go_sdk_version: ${{ steps.release.outputs['sdk/go--version'] }}
3737
go_sdk_tag: ${{ steps.release.outputs['sdk/go--tag_name'] }}
38-
rust_sdk_released: ${{ steps.release.outputs['sdk--release_created'] }}
39-
rust_sdk_version: ${{ steps.release.outputs['sdk--version'] }}
40-
rust_sdk_tag: ${{ steps.release.outputs['sdk--tag_name'] }}
38+
rust_sdk_released: ${{ steps.release.outputs['sdk/rust--release_created'] }}
39+
rust_sdk_version: ${{ steps.release.outputs['sdk/rust--version'] }}
40+
rust_sdk_tag: ${{ steps.release.outputs['sdk/rust--tag_name'] }}
4141
python_sdk_released: ${{ steps.release.outputs['sdk/python--release_created'] }}
4242
python_sdk_version: ${{ steps.release.outputs['sdk/python--version'] }}
4343
python_sdk_tag: ${{ steps.release.outputs['sdk/python--tag_name'] }}
@@ -71,7 +71,7 @@ jobs:
7171
echo "Releases created: ${{ steps.release.outputs.releases_created }}"
7272
echo "CLI released: ${{ steps.release.outputs['cmd/ftl--release_created'] }}"
7373
echo "Go SDK released: ${{ steps.release.outputs['sdk/go--release_created'] }}"
74-
echo "Rust SDK released: ${{ steps.release.outputs['sdk--release_created'] }}"
74+
echo "Rust SDK released: ${{ steps.release.outputs['sdk/rust--release_created'] }}"
7575
echo "Python SDK released: ${{ steps.release.outputs['sdk/python--release_created'] }}"
7676
echo "TypeScript SDK released: ${{ steps.release.outputs['sdk/typescript--release_created'] }}"
7777
echo "Components released: ${{ steps.release.outputs['components--release_created'] }}"

.github/workflows/release-rust-crates.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ jobs:
4646
fi
4747
4848
# Check manifest version
49-
JSON_VERSION=$(jq -r '."sdk"' .release-please-manifest.json)
49+
JSON_VERSION=$(jq -r '."sdk/rust"' .release-please-manifest.json)
5050
if [[ "${JSON_VERSION}" != "${VERSION}" ]]; then
5151
echo "Version mismatch in manifest: found ${JSON_VERSION}, expected ${VERSION}"
5252
exit 1

.github/workflows/release-validation.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -169,8 +169,8 @@ jobs:
169169
done
170170
171171
# Check Rust SDK
172-
RUST_SDK_MANIFEST=$(echo "$MANIFEST_VERSIONS" | jq -r '."sdk"')
173-
RUST_SDK_SCAFFOLD=$(jq -r '."sdk"' .release-please-manifest.json)
172+
RUST_SDK_MANIFEST=$(echo "$MANIFEST_VERSIONS" | jq -r '."sdk/rust"')
173+
RUST_SDK_SCAFFOLD=$(jq -r '."sdk/rust"' .release-please-manifest.json)
174174
175175
if [[ "$RUST_SDK_MANIFEST" != "$RUST_SDK_SCAFFOLD" ]]; then
176176
if [[ "$IS_RELEASE_PR" == "true" ]]; then
@@ -216,7 +216,7 @@ jobs:
216216
fi
217217
218218
# Check Rust SDK workspace version
219-
MANIFEST_VERSION=$(jq -r '."sdk"' .release-please-manifest.json)
219+
MANIFEST_VERSION=$(jq -r '."sdk/rust"' .release-please-manifest.json)
220220
WORKSPACE_VERSION=$(grep '^\s*version = ' sdk/Cargo.toml | head -1 | cut -d'"' -f2)
221221
222222
if [[ "$MANIFEST_VERSION" != "$WORKSPACE_VERSION" ]]; then
@@ -337,7 +337,7 @@ jobs:
337337
- name: Check Rust SDK dependencies
338338
run: |
339339
# Ensure ftl-sdk depends on correct ftl-sdk-macros version
340-
SDK_VERSION=$(jq -r '."sdk"' .release-please-manifest.json)
340+
SDK_VERSION=$(jq -r '."sdk/rust"' .release-please-manifest.json)
341341
MACROS_DEP=$(grep 'ftl-sdk-macros.*version' sdk/rust/Cargo.toml | cut -d'"' -f2)
342342
343343
if [[ "$MACROS_DEP" != "=$SDK_VERSION" ]] && [[ "$MACROS_DEP" != "$SDK_VERSION" ]]; then
@@ -358,7 +358,7 @@ jobs:
358358
# Extract component dependencies
359359
if grep -q "rust-sdk" "$ftl_file"; then
360360
EXAMPLE_VERSION=$(grep "rust-sdk" "$ftl_file" | grep -oP 'v\K[0-9.]+' || echo "unknown")
361-
EXPECTED_VERSION=$(jq -r '."sdk"' .release-please-manifest.json)
361+
EXPECTED_VERSION=$(jq -r '."sdk/rust"' .release-please-manifest.json)
362362
363363
if [[ "$EXAMPLE_VERSION" != "$EXPECTED_VERSION" ]] && [[ "$EXAMPLE_VERSION" != "unknown" ]]; then
364364
echo " ⚠️ Example uses rust-sdk v$EXAMPLE_VERSION, expected v$EXPECTED_VERSION"

.release-please-manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
".": "0.12.0",
33
"cmd/ftl": "0.11.0",
44
"sdk/go": "0.11.0",
5-
"sdk": "0.12.0",
5+
"sdk/rust": "0.12.0",
66
"sdk/python": "0.11.0",
77
"sdk/typescript": "0.11.1",
88
"components": "0.14.0"

release-please-config.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@
128128
}
129129
]
130130
},
131-
"sdk": {
131+
"sdk/rust": {
132132
"release-type": "rust",
133133
"component": "sdk-rust",
134134
"changelog-path": "CHANGELOG.md",
@@ -137,7 +137,6 @@
137137
"package-name": "ftl-sdk",
138138
"bootstrap-sha": "162b1781c1e9ff7accc1369177c83a02fb174dbe",
139139
"last-release-sha": "162b1781c1e9ff7accc1369177c83a02fb174dbe",
140-
"path": "sdk/rust",
141140
"extra-files": [
142141
{
143142
"type": "toml",

0 commit comments

Comments
 (0)